new time driving function handling #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very nice! I don't see a problem with the different variants of You could move I didn't make a detailed review yet, most of the things from #125 apply here, too. |
mgeier
reviewed
Mar 13, 2019
narahahn
requested changes
Mar 13, 2019
sfs/time/nfchoa.py
Outdated
| Second-order section filters :func:`scipy.signal.sosfilt`. | ||
| phaseshift : (N,) numpy.ndarray | ||
| Phase shift in radians. | ||
|
|
There was a problem hiding this comment.
Add selection and secondary_source.
sfs/time/nfchoa.py
Outdated
| Second-order section filters :func:`scipy.signal.sosfilt`. | ||
| phaseshift : (N,) numpy.ndarray | ||
| Phase shift in radians. | ||
|
|
There was a problem hiding this comment.
Add selection and secondary_source
sfs/time/nfchoa.py
Outdated
| Second-order section filters :func:`scipy.signal.sosfilt`. | ||
| phaseshift : (N,) numpy.ndarray | ||
| Phase shift in radians. | ||
|
|
There was a problem hiding this comment.
Add selection and secondary_source
sfs/time/wfs.py
Outdated
| import numpy as np | ||
| from numpy.core.umath_tests import inner1d # element-wise inner product | ||
| from scipy.signal import besselap, sosfilt, zpk2sos | ||
| from scipy.special import eval_legendre as legendre |
There was a problem hiding this comment.
These functions are not used here.
sfs/time/wfs.py
Outdated
| """ | ||
| import numpy as np | ||
| from numpy.core.umath_tests import inner1d # element-wise inner product | ||
| from scipy.signal import besselap, sosfilt, zpk2sos |
sfs/time/wfs.py
Outdated
| return util.DelayedSignal(out, samplerate, offset_samples / samplerate) | ||
|
|
||
|
|
||
| def secondary_source_point(c): |
There was a problem hiding this comment.
In nfchoa, this function comes at the top of the script.
Maybe we can move it for a more uniform look?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same idea as of #125
Additionally compared to frequency domain, here the handling of
def driving_signalsanddef apply_delaysshould be handled more elegant. I'm currently testing some ideas.