new time driving function handling #126
Conversation
|
Very nice! I don't see a problem with the different variants of You could move I didn't make a detailed review yet, most of the things from #125 apply here, too. |
sfs/time/nfchoa.py
Outdated
| Second-order section filters :func:`scipy.signal.sosfilt`. | ||
| phaseshift : (N,) numpy.ndarray | ||
| Phase shift in radians. | ||
|
|
There was a problem hiding this comment.
Add selection and secondary_source.
sfs/time/nfchoa.py
Outdated
| Second-order section filters :func:`scipy.signal.sosfilt`. | ||
| phaseshift : (N,) numpy.ndarray | ||
| Phase shift in radians. | ||
|
|
There was a problem hiding this comment.
Add selection and secondary_source
sfs/time/nfchoa.py
Outdated
| Second-order section filters :func:`scipy.signal.sosfilt`. | ||
| phaseshift : (N,) numpy.ndarray | ||
| Phase shift in radians. | ||
|
|
There was a problem hiding this comment.
Add selection and secondary_source
sfs/time/wfs.py
Outdated
| import numpy as np | ||
| from numpy.core.umath_tests import inner1d # element-wise inner product | ||
| from scipy.signal import besselap, sosfilt, zpk2sos | ||
| from scipy.special import eval_legendre as legendre |
There was a problem hiding this comment.
These functions are not used here.
sfs/time/wfs.py
Outdated
| """ | ||
| import numpy as np | ||
| from numpy.core.umath_tests import inner1d # element-wise inner product | ||
| from scipy.signal import besselap, sosfilt, zpk2sos |
sfs/time/wfs.py
Outdated
| return util.DelayedSignal(out, samplerate, offset_samples / samplerate) | ||
|
|
||
|
|
||
| def secondary_source_point(c): |
There was a problem hiding this comment.
In nfchoa, this function comes at the top of the script.
Maybe we can move it for a more uniform look?
|
@narahahn Those other comments seem outdated anyway, right? |
Same idea as of #125
Additionally compared to frequency domain, here the handling of
def driving_signalsanddef apply_delaysshould be handled more elegant. I'm currently testing some ideas.