8000 xpath: Let the parents of attribute nodes be their owner elements by simonwuelker · Pull Request #39749 · servo/servo · GitHub
[go: up one dir, main page]
Skip to content

xpath: Let the parents of attribute nodes be their owner elements #39749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
simonwuelker merged 2 commits into from
Oct 10, 2025
Merged

xpath: Let the parents of attribute nodes be their owner elements #39749

simonwuelker merged 2 commits into from
Oct 10, 2025

Conversation

@simonwuelker
Copy link
Contributor
@simonwuelker simonwuelker commented Oct 9, 2025

This is different from the rest of the DOM, see https://www.w3.org/TR/1999/REC-xpath-19991116/#attribute-nodes. Luckily, this can cleanly be implemented for XPath because we already abstract over the concrete DOM implementation.

Testing: This change adds a test
Part of #34527

@simonwuelker
xpath: Let the parents of attribute nodes be their owner elements
58e4184 
Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
@simonwuelker simonwuelker requested a review from gterzian as a code owner October 9, 2025 21:02
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Oct 9, 2025
@servo-wpt-sync servo-wpt-sync mentioned this pull request Oct 9, 2025
Merged
@servo-wpt-sync
Copy link
Collaborator
servo-wpt-sync commented Oct 9, 2025

🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#55339) with upstreamable changes.

@simonwuelker simonwuelker force-pushed the xpath-attr-nodes-element-parents branch from 1f9a881 to e11cd48 Compare October 9, 2025 21:31
@simonwuelker
Add web platform test
d4f2a05 
Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
@simonwuelker simonwuelker force-pushed the xpath-attr-nodes-element-parents branch from e11cd48 to d4f2a05 Compare October 9, 2025 21:32
@servo-wpt-sync
Copy link
Collaborator
servo-wpt-sync commented Oct 9, 2025

📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#55339).

1 similar comment
@servo-wpt-sync
Copy link
Collaborator
servo-wpt-sync commented Oct 9, 2025

📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#55339).

yezhizhen
yezhizhen approved these changes Oct 10, 2025
View reviewed changes
Copy link
Member
@yezhizhen yezhizhen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!

@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Oct 10, 2025
@simonwuelker simonwuelker added this pull request to the merge queue Oct 10, 2025
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Oct 10, 2025
Merged via the queue into servo:main with commit a037ef0 Oct 10, 2025
25 checks passed
@simonwuelker simonwuelker 86D3 deleted the xpath-attr-nodes-element-parents branch October 10, 2025 05:38
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Loirooriol Loirooriol Loirooriol left review comments

@yezhizhen yezhizhen yezhizhen approved these changes

@gterzian gterzian Awaiting requested review from gterzian gterzian is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@simonwuelker @servo-wpt-sync @Loirooriol @yezhizhen @servo-highfive
0