xpath: Let the parents of attribute nodes be their owner elements #39749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
Collaborator
|
🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#55339) with upstreamable changes. |
Loirooriol
reviewed
Oct 9, 2025
1f9a881 to
e11cd48
Compare
Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
e11cd48 to
d4f2a05
Compare
Collaborator
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#55339). |
1 similar comment
Collaborator
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#55339). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is different from the rest of the DOM, see https://www.w3.org/TR/1999/REC-xpath-19991116/#attribute-nodes. Luckily, this can cleanly be implemented for XPath because we already abstract over the concrete DOM implementation.
Testing: This change adds a test
Part of #34527