Remove Webdriver Server's access to Constellation #38212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Euclid Ye <euclid.ye@huawei.com>
yezhizhen
commented
Jul 22, 2025
| "WebDriverCommand {:?} is still not moved from constellation to embedder", | ||
| msg | ||
| ); | ||
| running_state.forward_webdriver_command(msg); |
There was a problem hiding this comment.
Btw I don't understand why we have both
servo/ports/servoshell/desktop/app_state.rs
Lines 162 to 164 in 61df7ab
Lines 1063 to 1066 in 61df7ab
xiaochengh
approved these changes
Jul 22, 2025
| "WebDriverCommand {:?} is still not moved from constellation to embedder", | ||
| msg | ||
| ); | ||
| running_state.forward_webdriver_command(msg); |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 24, 2025
…log for script::`handle_send_keys_non_typeable` (#38238) There was a new commit for after #38189 (comment), but that does not seem to update/stop MQ. Also removed `forward_webdriver_command` in servoshell according to #38212 (comment). --------- Signed-off-by: Euclid Ye <euclid.ye@huawei.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebDriverCommandMsg::TakeScreenshotwas the last thing blocking us from removing constellation access in webdriver server. Now we can happily remove it.Surprisingly, this reduces binary size by 185KB for release profile in Windows. #37737 removes a net total of 300 lines, but only reduced 98KB.
Testing: No regression after testing.