[WebDriver] Reuse "Find Elements" handler in "Find element" #37737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
wusyong
requested changes
Jun 27, 2025
Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
wusyong
approved these changes
Jun 27, 2025
Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 22, 2025
`WebDriverCommandMsg::TakeScreenshot` was the last thing blocking us from removing constellation access in webdriver server. Now we can happily remove it. Surprisingly, this reduces binary size by 185KB for release profile in Windows. #37737 removes a net total of 300 lines, but only reduced 98KB. Testing: No regression after testing. Signed-off-by: Euclid Ye <euclid.ye@huawei.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All "Find Element ..." in spec has exactly same step has "Find Elements ...", except they extract the first element if there is any. We now reuse the handler instead of running numerous repetitive steps, same as what we did for "Find Element from Shadow Root" in #37578.
This reduces binary size by 98KB for Release profile in Windows and improves maintainability.
Testing:
./mach test-wpt -r .\tests\wpt\tests\webdriver\tests\classic\find_element* --product servodriver