8000 Implement setting position through webdriver for headed window by yezhizhen · Pull Request #38209 · servo/servo · GitHub
[go: up one dir, main page]

Skip to content

Conversation

yezhizhen
Copy link
Member
@yezhizhen yezhizhen commented Jul 22, 2025

Previously, we pretend we are able to set position in response. Now we can really do it.

Testing: Able to set position accurately when tested locally.
Fixes: Task 5 of #37804.

Signed-off-by: Euclid Ye <euclid.ye@huawei.com>
Signed-off-by: Euclid Ye <euclid.ye@huawei.com>
@yezhizhen yezhizhen requested a review from atbrakhi as a code owner July 22, 2025 04:42
@yezhizhen yezhizhen requested review from jdm and xiaochengh July 22, 2025 04:42
@yezhizhen
Copy link
Member Author
Screen.Recording.2025-07-22.150103.mp4

Copy link
Member
@jdm jdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clear!

@jdm jdm added this pull request to the merge queue Jul 22, 2025
Merged via the queue into servo:main with commit 4ff6b1d Jul 22, 2025
22 checks passed
PotatoCP added a commit to PotatoCP/servo that referenced this pull request Jul 23, 2025
…#38209) (wd)

{"fail_fast": false, "matrix": [{"name": "Linux (WPT)", "workflow": "linux", "wpt": true, "profile": "release", "unit_tests": false, "build_libservo": false, "bencher": false, "build_args": "", "wpt_args": "./tests/wpt/tests/webdriver/tests/classic/ --product servodriver --headless --processes 1", "number_of_wpt_chunks": 2}]}
@yezhizhen yezhizhen deleted the improve-set-rect branch July 23, 2025 01:52
longvatrong111 added a commit to longvatrong111/servo that referenced this pull request Jul 23, 2025
…#38209) (wd)

{"fail_fast": false, "matrix": [{"name": "Linux (WPT)", "workflow": "linux", "wpt": true, "profile": "release", "unit_tests": false, "build_libservo": false, "bencher": false, "build_args": "", "wpt_args": "./tests/wpt/tests/webdriver/tests/classic/ --product servodriver --headless --processes 1", "number_of_wpt_chunks": 2}]}
longvatrong111 added a commit to longvatrong111/servo that referenced this pull request Jul 23, 2025
…#38209) (wd)

{"fail_fast": false, "matrix": [{"name": "Linux (WPT)", "workflow": "linux", "wpt": true, "profile": "release", "unit_tests": false, "build_libservo": false, "bencher": false, "build_args": "", "wpt_args": "./tests/wpt/tests/webdriver/tests/classic/ --product servodriver --headless --processes 1", "number_of_wpt_chunks": 2}]}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0