-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Closed
Copy link
Labels
Description
Creating this to track progress. I found these bugs by reading code & doing experiment.
Describe the bug:
- Get window rect always returns entire screen dimension because we wrongly use
fn screen_geometry
. - We always return {x:0, y:0}. We can implement this properly.
- Set window Rect sets only the inner size, regardless of the toolbar height.
- All operations should done w.r.t. CSS pixel instead of Device pixel, according to spec.
- Set window Rect right now only set window size but not position.
- Should not use
toolbar_height
to calculate window size. This will always overshoot. - Add position for Headless window. Right now, it's always (0, 0).
- Set window Rect always assumes the resize is successful and returns the requested size.
To Reproduce:
./mach run -r
- Send https request to create session and get window rect
Platform:
Windows. But I believe Mac/Linux also broken in the same way based on code.