8000 servoshell: Select address bar text on click by MichaelMcDonnell · Pull Request #37839 · servo/servo · GitHub
[go: up one dir, main page]
Skip to content

servoshell: Select address bar text on click #37839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2025
Merged

servoshell: Select address bar text on click #37839

merged 1 commit into from
Jul 3, 2025

Conversation

MichaelMcDonnell
Copy link
Contributor

In Firefox, clicking on the address bar selects all the text. This makes Servo to do the same. I reworked the code so that the shortcut only changes the focus. That means that either clicking or the shortcut changes the focus which in turn selects the text.

Testing: I tested it manually by clicking in the address bar and using the shortcuts and noticing that the text was selected.

@MichaelMcDonnell @mrobinson
Select address bar text on click
9d47344 
In Firefox, clicking on the address bar selects all the text. This
makes Servo to do the same. I reworked the code so that the shortcut
only changes the focus. That means that either clicking or the shortcut
changes the focus which in turn selects the text.

Signed-off-by: Michael Mc Donnell <michael@mcdonnell.dk>
@mrobinson mrobinson force-pushed the select-address-on-click branch from 394ccd9 to 9d47344 Compare July 3, 2025 13:27
@mrobinson mrobinson changed the title Select address bar text on click servoshell: Select address bar text on click Jul 3, 2025
@mrobinson mrobinson enabled auto-merge July 3, 2025 13:27
@mrobinson mrobinson added this pull request to the merge queue Jul 3, 2025
Merged via the queue into servo:main with commit e3baec4 Jul 3, 2025
22 checks passed
@MichaelMcDonnell MichaelMcDonnell deleted the select-address-on-click branch July 3, 2025 15:31
@MichaelMcDonnell
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrobinson mrobinson mrobinson approved these changes

@atbrakhi atbrakhi Awaiting requested review from atbrakhi atbrakhi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaelMcDonnell @mrobinson
0