servoshell: Select address bar text on click (#37839)

MichaelMcDonnell · web-flow · commit e3baec48073c · 2025-07-03T14:04:02.000Z
In Firefox, clicking on the address bar selects all the text. This makes
Servo to do the same. I reworked the code so that the shortcut only
changes the focus. That means that either clicking or the shortcut
changes the focus which in turn selects the text.

Testing: I tested it manually by clicking in the address bar and using
the shortcuts and noticing that the text was selected.

Signed-off-by: Michael Mc Donnell &lt;michael@mcdonnell.dk&gt;
diff --git a/ports/servoshell/desktop/minibrowser.rs b/ports/servoshell/desktop/minibrowser.rs
@@ -340,7 +340,11 @@ impl Minibrowser {
                                                 i.clone().consume_key(Modifiers::ALT, Key::D)
                                         }
                                     }) {
+                                        // The focus request immediately makes gained_focus return true.
                                         location_field.request_focus();
+                                    }
+                                    // Select address bar text when it's focused (click or shortcut).
+                                    if location_field.gained_focus() {
                                         if let Some(mut state) =
                                             TextEditState::load(ui.ctx(), location_id)
                                         {
@@ -352,6 +356,7 @@ impl Minibrowser {
                                             state.store(ui.ctx(), location_id);
                                         }
                                     }
+                                    // Navigate to address when enter is pressed in the address bar.
                                     if location_field.lost_focus() &&
                                         ui.input(|i| i.clone().key_pressed(Key::Enter))
                                     {

Original file line number	Diff line number	Diff line change
`@@ -340,7 +340,11 @@ impl Minibrowser {`
`340`	`340`	`i.clone().consume_key(Modifiers::ALT, Key::D)`
`341`	`341`	`}`
`342`	`342`	`}) {`
	`343`	`+ // The focus request immediately makes gained_focus return true.`
`343`	`344`	`location_field.request_focus();`
	`345`	`+ }`
	`346`	`+ // Select address bar text when it's focused (click or shortcut).`
	`347`	`+ if location_field.gained_focus() {`
`344`	`348`	`if let Some(mut state) =`
`345`	`349`	`TextEditState::load(ui.ctx(), location_id)`
`346`	`350`	`{`
`@@ -352,6 +356,7 @@ impl Minibrowser {`
`352`	`356`	`state.store(ui.ctx(), location_id);`
`353`	`357`	`}`
`354`	`358`	`}`
	`359`	`+ // Navigate to address when enter is pressed in the address bar.`
`355`	`360`	`if location_field.lost_focus() &&`
`356`	`361`	`ui.input(\|i\| i.clone().key_pressed(Key::Enter))`
`357`	`362`	`{`