8000 Fixes misformatted upgrade changelog in the SCB bot's generated PR by Ilyesbdlala · Pull Request #823 · secureCodeBox/secureCodeBox · GitHub
[go: up one dir, main page]
Skip to content

Fixes misformatted upgrade changelog in the SCB bot's generated PR #823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
malexmave merged 5 commits into from
Nov 22, 2021
Merged

Fixes misformatted upgrade changelog in the SCB bot's generated PR #823

malexmave merged 5 commits into from
Nov 22, 2021

Conversation

@Ilyesbdlala
Copy link
Member
@Ilyesbdlala Ilyesbdlala commented Nov 16, 2021 •
edited
Loading

closes #818

Description

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure npm test runs for the whole project.
  • Make codeclimate checks happy

@Ilyesbdlala
added sed expression to filter out issues numbers (i.e #123)
b8ef6e0 
commented out unnecesarry part for testing and added on push trigger

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
@Ilyesbdlala Ilyesbdlala added the bug Bugs label Nov 16, 2021
@Ilyesbdlala Ilyesbdlala added this to the v3.4.0 milestone Nov 16, 2021
@Ilyesbdlala Ilyesbdlala self-assigned this Nov 16, 2021
@Ilyesbdlala
restore commented out section in scb bot
0cbef11 
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
@Ilyesbdlala
Merge branch 'main' into bugfix/scb-bot-pr-changelog
9d995f4 
This is done to get it inline with the #819 PR
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
@Ilyesbdlala
Fix typo in the scb-bot.yaml
a8cd424 
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
@Ilyesbdlala
Removed on push trigger for the scb bot
dc4fe51 
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
@Ilyesbdlala Ilyesbdlala marked this pull request as ready for review November 17, 2021 11:00
@malexmave malexmave merged commit bbe5b5d into main Nov 22, 2021
@malexmave malexmave deleted the bugfix/scb-bot-pr-changelog branch November 22, 2021 09:58
@snyk-bot snyk-bot mentioned this pull request Jul 19, 2022
Merged
@snyk-bot snyk-bot mentioned this pull request Aug 9, 2022
Merged
@snyk-bot snyk-bot mentioned this pull request Aug 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malexmave malexmave malexmave approved these changes

Assignees

@Ilyesbdlala Ilyesbdlala

Labels

bug Bugs

Projects

None yet

Milestone

v3.4.0

Development

Successfully merging this pull request may close these issues.

[SCB-BOT] misformatted upgrade changelog in the generated PR

3 participants

@Ilyesbdlala @malexmave
0