Add ability to configure affinity and tolerations for scans and hooks #804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Max Maass <max.maass@iteratec.com>
Signed-off-by: Max Maass <max.maass@iteratec.com>
Signed-off-by: Max Maass <max.maass@iteratec.com>
Signed-off-by: Max Maass <max.maass@iteratec.com>
Signed-off-by: Max Maass <max.maass@iteratec.com>
Signed-off-by: Max Maass <max.maass@iteratec.com>
4a6f685 to
206517a
Compare
Signed-off-by: GitHub Actions <securecodebox@iteratec.com>
Member
Author
|
Okay, I broke something with my attempts to get this back on top of main, and even force-pushing this branch did not fix it. Since there isn't a lot of interesting history yet, I'll close this PR and open a new one that is less borked. |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves #803 by adding affinity and tolerations to the ScanSpec and ScanCompletionHookSpec.
Currently in draft state. Tasks:
ScanSpecandScanCompletionHookSpecCRDs and re-generate themI will try to wrap this up later today so we can release it as part of 3.4 - that way the inconvenience of having to manually update CRDs can be lessened, as a CRD update is necessary anyway because of the new hook features. (Not looking forward to the merge conflicts - perhaps we should merge the other two PRs so I can quickly rebase on that branch to avoid that pain down the road?)