Cache SDK Images As Artifacts #655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
The docker-meta-action seems to be a little flaky at the moment. |
d2a7007 to
ef6b647
Compare
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
I refactored the sdk image builds to use the makefiles and uploaded the created images as artifacts to be able to remove the Registry secrets from the workflow. Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
The default build driver for the used buildx action is `docker-container`. This means the image is build within a buildkit container with no access to images loaded into docker. This is a problem because we need to import the base images for parser-sdk and hook-sdk to build the images for parsers and hooks without using a container registry caching these base images. To fix this I changed the build driver to `docker` to build the image with the docker daemon. See: https://github.com/docker/setup-buildx-action github.com/docker/buildx/blob/master/docs/reference/buildx_create.md#driver Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
I changed the number of retention days to one because this pipeline is used for developement only. Release Images are build using a special build pipeline and pushed to docker hub. Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
8c01bcc to
d823f5a
Compare
J12934
approved these changes
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If applied, this PR (depends on PR #653) will