8000 Remove underscore in container name by Reet00 · Pull Request #2903 · secureCodeBox/secureCodeBox · GitHub
[go: up one dir, main page]
Skip to content

Remove underscore in container name #2903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
J12934 merged 2 commits into from
Mar 6, 2025
Merged

Remove underscore in container name #2903

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea485ae
#2706 Remove underscore in container name since it is allowed in ima…
Reet00 Feb 13, 2025
39d81e3
Add unit-test for image with underscore
Reet00 Mar 6, 2025
File filter

Filter by extension

Filter by extension 8000
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions auto-discovery/kubernetes/controllers/container_scan_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,7 @@ func getScanName(imageID string, scanConfig config.ScanConfig) string {

result = strings.ReplaceAll(result, ".", "-")
result = strings.ReplaceAll(result, "/", "-")
result = strings.ReplaceAll(result, "_", "-")

//limit scan name length to kubernetes limits
return result[:62]
Expand Down
24 changes: 24 additions & 0 deletions auto-discovery/kubernetes/controllers/container_scan_controller_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,30 @@ var _ = Describe("ContainerScan controller", func() {
!checkIfScanExists(ctx, juiceShopScanName2, namespace, juiceShopScanGoTemplate)
}, timeout, interval).Should(BeTrue())
})

It("Should create a scan for an image with underscores", func() {
fakeDeployment2 := map[string]string{"test_image": "1237b565c37bcbd895e9d92315a05c1c3c9a29f762b011a10c54a66cd53c9b31"}

createPodWithMultipleContainers(ctx, "fake-deployment-pod3", namespace, fakeDeployment2)
testScanName1 := "test-image-test-scan-at-1237b565c37bcbd895e9d92315a05c1c3c9a29f762b011a10c54a66cd53c9b31"
testScanName1 = testScanName1[:62]

testScanGoTemplate := scanGoTemplate{
map[string]string{"testAnnotation": namespace},
map[string]string{
"testLabel": namespace,
"app.kubernetes.io/managed-by": "securecodebox-autodiscovery",
},
[]string{"-p", namespace},
nil,
nil,
nil,
}
Eventually(func() bool {
return checkIfScanExists(ctx, testScanName1, namespace, testScanGoTemplate)
}, timeout, interval).Should(BeTrue())
})

})
Context("Container autodiscovery with imagePullSecrets", func() {
namespace := "container-autodiscovery-imagepullsecrets"
Expand Down
Loading
0