10BC0 Renamed the docker images of demo-targets to include a "demo-target-" prefix by Ilyesbdlala · Pull Request #1360 · secureCodeBox/secureCodeBox · GitHub
[go: up one dir, main page]
Skip to content

Renamed the docker images of demo-targets to include a "demo-target-" prefix #1360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
J12934 merged 3 commits into from
Sep 28, 2022
Merged

Renamed the docker images of demo-targets to include a "demo-target-" prefix #1360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9b54da5
ci(demo-target): Renamed the docker images of demo-targets to include…
Ilyesbdlala Sep 15, 2022
fe15b5a
docs(demo-target): Included a notice in the UPGRADING.md for changes …
Ilyesbdlala Sep 22, 2022
4d06fef
docs(demo-target): Fixed wrong comments in values.yaml files for the …
Ilyesbdlala Sep 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/release-build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -516,7 +516,7 @@ jobs:
id: docker_meta
uses: docker/metadata-action@v3
with:
images: ${{ env.DOCKER_NAMESPACE }}/${{ matrix.target }}
images: ${{ env.DOCKER_NAMESPACE }}/demo-target-${{ matrix.target }}
tags: |
type=sha
latest
Expand Down Expand Up @@ -546,5 +546,5 @@ jobs:
with:
username: ${{ secrets.DOCKERHUB_USERNAME }}
password: ${{ secrets.DOCKERHUB_PASSWORD }}
repository: ${{ env.DOCKER_NAMESPACE }}/${{ matrix.target }}
repository: ${{ env.DOCKER_NAMESPACE }}/demo-target-${{ matrix.target }}
readme-filepath: ./demo-targets/${{ matrix.target }}/docs/README.DockerHub-Target.md
13 changes: 12 additions & 1 deletion UPGRADING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,4 +123,15 @@ kubectl --namespace <NAMESPACE> delete role lurcher
### Removed Hook Teams Webhook
We implemented a more general *[notification hook](https://www.securecodebox.io/docs/hooks/notification-hook)* which can be used to notify different systems like *[MS Teams](https://www.securecodebox.io/docs/hooks/notification-hook#configuration-of-a-ms-teams-notification)* and *[Slack](https://www.securecodebox.io/docs/hooks/notification-hook#configuration-of-a-slack-notification)* and also [Email](https://www.securecodebox.io/docs/hooks/notification-hook#configuration-of-an-email-notification) based in a more flexible way with [custom message templates](https://www.securecodebox.io/docs/hooks/notification-hook#custom-message-templates). With this new hook in place it is not nessesary to maintain the preexisting MS Teams Hook any longer and therefore we removed it.

➡️ [Reference: #570](https://github.com/secureCodeBox/secureCodeBox/pull/570)
➡️ [Reference: #570](https://github.com/secureCodeBox/secureCodeBox/pull/570)

## From 3.X to 4.X
### Renamed the docker images of demo-targets to include a "demo-target-" prefix
The docker images for the custom demo targets built by secureCodeBox to include a "demo-target-" prefix i.e:
* securecodebox/old-typo3 --> securecodebox/**demo-target**-old-typo3
* securecodebox/old-joomla --> securecodebox/**demo-target**-old-joomla
* securecodebox/old-wordpress --> securecodebox/**demo-target**-old-wordpress

These images are usually used for testing and demo purposes. If you use these images, you would have to rename them appropriately.

➡️ [Reference: #1360](https://github.com/secureCodeBox/secureCodeBox/pull/1360)
4 changes: 2 additions & 2 deletions demo-targets/old-joomla/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,15 @@
#
# SPDX-License-Identifier: Apache-2.0

# Default values for old-wordpress.
# Default values for demo-target-old-joomla.
# This is a YAML-formatted file.
# Declare variables to be passed into your templates.

replicaCount: 1

image:
# image.repository -- Container Image
repository: docker.io/securecodebox/old-joomla
repository: docker.io/securecodebox/demo-target-old-joomla
# image.tag -- The image tag
# @default -- defaults to the appVersion
tag: null
Expand Down
4 changes: 2 additions & 2 deletions demo-targets/old-typo3/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,15 @@
#
# SPDX-License-Identifier: Apache-2.0

# Default values for old-wordpress.
# Default values for demo-target-old-typo3.
# This is a YAML-formatted file.
# Declare variables to be passed into your templates.

replicaCount: 1

image:
# image.repository -- Container Image
repository: docker.io/securecodebox/old-typo3
B80B repository: docker.io/securecodebox/demo-target-old-typo3
# image.tag -- The image tag
# @default -- defaults to the appVersion
tag: v9.4
Expand Down
4 changes: 2 additions & 2 deletions demo-targets/old-wordpress/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,15 @@
#
# SPDX-License-Identifier: Apache-2.0

# Default values for old-wordpress.
# Default values for demo-target-old-wordpress.
# This is a YAML-formatted file.
# Declare variables to be passed into your templates.

replicaCount: 1

image:
# image.repository -- Container Image
repository: docker.io/securecodebox/old-wordpress
repository: docker.io/securecodebox/demo-target-old-wordpress
# image.tag -- The image tag
# @default -- defaults to the appVersion
tag: null
Expand Down
0