8000 Renamed the docker images of demo-targets to include a "demo-target-" prefix by Ilyesbdlala · Pull Request #1360 · secureCodeBox/secureCodeBox · GitHub
[go: up one dir, main page]
Skip to content

Renamed the docker images of demo-targets to include a "demo-target-" prefix #1360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
J12934 merged 3 commits into from
Sep 28, 2022
Merged

Renamed the docker images of demo-targets to include a "demo-target-" prefix #1360

J12934 merged 3 commits into from
Sep 28, 2022

Conversation

@Ilyesbdlala
Copy link
Member
@Ilyesbdlala Ilyesbdlala commented Sep 15, 2022 •
edited
Loading

Closes #720
This PR changes how the name of demo-targets when released. As a result the CI will fail as long a new release has not been made with the new demo-targets name, that includes this PR.

Signed-off-by: Ilyes Ben Dlala ilyes.bendlala@iteratec.com

Description

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure that all your commits are signed-off and that you are added to the Contributors file.
  • Make sure that all CI finish successfully.
  • Optional (but appreciated): Make sure that all commits are Verified.

@Ilyesbdlala Ilyesbdlala added ci Changes to the continuous integration setup breaking Changes requiring a major release labels Sep 15, 2022
@Ilyesbdlala Ilyesbdlala self-assigned this Sep 15, 2022
@github-actions
Copy link
github-actions bot commented Sep 15, 2022 •
edited
Loading

MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
⚠️ ACTION actionlint 1 3 0.04s
✅ SPELL misspell 4 0 0.06s
✅ YAML prettier 4 0 0.94s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

@malexmave malexmave added this to the v4.0.0 milestone Sep 20, 2022
@Ilyesbdlala
ci(demo-target): Renamed the docker images of demo-targets to include…
9b54da5 
… a "demo-target-" prefix

Closes ##720

BREAKING CHANGE:

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
@Ilyesbdlala
docs(demo-target): Included a notice in the UPGRADING.md for changes …
fe15b5a 
…to the demo-target names

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
@Ilyesbdlala Ilyesbdlala force-pushed the maintenance/demo-target-image-rename branch from 2814b26 to fe15b5a Compare September 23, 2022 13:46
Weltraumschaf
Weltraumschaf previously requested changes Sep 23, 2022
View reviewed changes
@Ilyesbdlala
docs(demo-target): Fixed wrong comments in values.yaml files for the …
4d06fef 
…demo-targets

Applied review suggestions

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
@J12934 J12934 merged commit 3d8dd0f into main Sep 28, 2022
@J12934 J12934 deleted the maintenance/demo-target-image-rename branch September 28, 2022 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@J12934 J12934 J12934 approved these changes

@Weltraumschaf Weltraumschaf Weltraumschaf left review comments

Assignees

@Ilyesbdlala Ilyesbdlala

Labels

breaking Changes requiring a major release ci Changes to the continuous integration setup

Projects

secureCodeBox
Archived in project

Milestone

v4.0.0

Development

Successfully merging this pull request may close these issues.

Prefix Demo Images On DockerHub

5 participants

@Ilyesbdlala @Weltraumschaf @J12934 @malexmave
0