8000 [MRG] DOC More detailed pull request and fork instructions (#8530) by tfolkman · Pull Request #8538 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

[MRG] DOC More detailed pull request and fork instructions (#8530) #8538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 7, 2017
Merged

[MRG] DOC More detailed pull request and fork instructions (#8530) #8538

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf2ab4f
DOC More detailed pull request and fork instructions (#8530)
tfolkman Mar 5, 2017
13a0db9
Mardkown tweaks
lesteve Mar 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@ GitHub, clone, and develop on a branch. Steps:

1. Fork the [project repository](https://github.com/scikit-learn/scikit-learn)
by clicking on the 'Fork' button near the top right of the page. This creates
a copy of the code under your GitHub user account.
a copy of the code under your GitHub user account. For more details on
how to fork a repository see [this guide](https://help.github.com/articles/fork-a-repo/).

2. Clone your fork of the scikit-learn repo from your GitHub account to your local disk:

Expand Down Expand Up @@ -48,9 +49,8 @@ GitHub, clone, and develop on a branch. Steps:
$ git push -u origin my-feature
```

5. Go to the GitHub web page of your fork of the scikit-learn repo.
Click the 'Pull request' button to send your changes to the project's maintainers for
review. This will send an email to the committers.
5. Follow [these instructions](https://help.github.com/articles/creating-a-pull-request-from-a-fork)
to create a pull request from your fork. This will send an email to the committers.

(If any of the above seems like magic to you, please look up the
[Git documentation](https://git-scm.com/documentation) on the web, or ask a friend or another contributor for help.)
Expand Down
12 changes: 7 additions & 5 deletions doc/developers/contributing.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,8 @@ then submit a "pull request" (PR):
2. Fork the `project repository
<https://github.com/scikit-learn/scikit-learn>`__: click on the 'Fork'
button near the top of the page. This creates a copy of the code under your
account on the GitHub server.
account on the GitHub server. For more details on how to fork a
repository see `this guide <https://help.github.com/articles/fork-a-repo/>`_.

3. Clone this copy to your local disk::

Expand All @@ -133,10 +134,11 @@ then submit a "pull request" (PR):

$ git push -u origin my-feature

Finally, go to the web page of the your fork of the scikit-learn repo,
and click 'Pull request' to send your changes to the maintainers for review.
You may want to consider sending an email to the mailing list for more
visibility.
Finally, follow `these
<https://help.github.com/articles/creating-a-pull-request-from-a-fork>`_
instructions to create a pull request from your fork. This will send an
email to the committers. You may want to consider sending an email to the
mailing list for more visibility.

.. note::

Expand Down
0