[MRG+1] TST fix generated test names #7412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deea41f to
0d0b484
Compare
|
Do you also wanna include the fix from #7348? |
|
LGTM |
|
I'm cleaning this all up. |
c7402f6 to
1578edd
Compare
|
sweet. +1 |
|
I wonder if this could more neatly be written as a decorator applied to each check. If so, should i hedge my bets and make |
|
I don't think it can be done as a decorator. Private would still be good, though, in particular if we're moving away from nose soonish. |
|
I think it can be done as a decorator, but i'll make the change to underscored. |
|
done |
|
Thanks! This is much nicer than before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An adjustment to #7317. Will show correct estimator names, where old version repeatedly overwrote an attribute on a function, leading to issues with execution order.