8000 [MRG+1] use inspect in _set_test_name to get the calling test. by amueller · Pull Request #7348 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

[MRG+1] use inspect in _set_test_name to get the calling test. #7348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[MRG+1] use inspect in _set_test_name to get the calling test. #7348

wants to merge 1 commit into from

Conversation

amueller
Copy link
Member
@amueller amueller commented Sep 6, 2016

Follow up on the comments in #7317.
Now it looks like

sklearn.tests.test_common.test_non_meta_estimators.check_pipeline_consistency(MultiTaskElasticNetCV) ... ok

That was the goal, right?

@amueller
Copy link
Member Author
amueller commented Sep 6, 2016

ping @jnothman @ogrisel

@amueller amueller mentioned this pull request Sep 13, 2016
Merged
@jnothman
Copy link
Member 
$ nosetests -sv sklearn/tests/test_common.py 2>&1 | grep -o [^.]*[.]check_ | sort -u
test_all_estimators.check_
test_class_weight_balanced_linear_classifiers.check_
test_get_params_invariance.check_
test_non_meta_estimators.check_
test_non_transformer_estimators_n_iter.check_
test_transformer_n_iter.check_

LGTM

@jnothman jnothman changed the title use inspect in _set_test_name to get the calling test. [MRG] use inspect in _set_test_name to get the calling test. Sep 14, 2016
@jnothman jnothman changed the title [MRG] use inspect in _set_test_name to get the calling test. [MRG+1] use inspect in _set_test_name to get the calling test. Sep 14, 2016
@jnothman
Copy link
Member

rolled into #7412

@jnothman jnothman closed this Sep 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amueller @jnothman
0