8000 FIX random failure in `test_solver_consistency` with SAG/SAGA solvers by ogrisel · Pull Request #31434 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

FIX random failure in test_solver_consistency with SAG/SAGA solvers #31434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 27, 2025
Merged

FIX random failure in test_solver_consistency with SAG/SAGA solvers #31434

merged 5 commits into from
May 27, 2025

Conversation

ogrisel
Copy link
Member
@ogrisel ogrisel commented May 27, 2025

This should resolve the failure detected in #31429.

@ogrisel
FIX random failure in test_ridge with SAG/SAGA solvers [azure paralle…
61aca86 
…l] [all random seeds]

test_solver_consistency
@github-actions GitHub Actions
Copy link
github-actions bot commented May 27, 2025 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: cc1c1fd. Link to the linter CI: here

@ogrisel ogrisel mentioned this pull request May 27, 2025
Merged
ogrisel added 2 commits May 27, 2025 11:21
@ogrisel
Tweak compare to a reference solver fit at the same precision level […
aee4ef6 
…azure parallel] [all random seeds]

test_solver_consistency
@ogrisel
Ensure no ConvergenceWarning by increasing tol and max_iter [azure pa…
96dc421 
…rallel] [all random seeds]

test_solver_consistency
@ogrisel ogrisel added No Changelog Needed module:test-suite everything related to our tests labels May 27, 2025
@ogrisel
Undo .astype move and tweak solver convergence params [azure parallel…
3c703b8 
…] [all random seeds]

test_solver_consistency
@ogrisel ogrisel added the Quick Review For PRs that are quick to review label May 27, 2025
lorentzenchr
lorentzenchr approved these changes May 27, 2025
View reviewed changes
Copy link
Member
@lorentzenchr lorentzenchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lorentzenchr lorentzenchr enabled auto-merge (squash) May 27, 2025 16:15
@lorentzenchr lorentzenchr merged commit b257fbb into scikit-learn:main May 27, 2025
8000 34 checks passed
jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request May 30, 2025
@ogrisel @jeremiedbb
FIX random failure in test_solver_consistency with SAG/SAGA solvers (…
f3b2521 
…scikit-learn#31434)
elhambbi pushed a commit to elhambbi/scikit-learn that referenced this pull request Jun 1, 2025
@ogrisel @elhambbi
FIX random failure in test_solver_consistency with SAG/SAGA solvers (…
967a081 
…scikit-learn#31434)
jeremiedbb pushed a commit that referenced this pull request Jun 5, 2025
@ogrisel @jeremiedbb
FIX random failure in test_solver_consistency with SAG/SAGA solvers (…
01c1621 
…#31434)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorentzenchr lorentzenchr lorentzenchr approved these changes

Assignees
No one assigned
Labels
module:linear_model module:test-suite everything related to our tests No Changelog Needed Quick Review For PRs that are quick to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ogrisel @lorentzenchr
0