8000 Fix BLAS_Order.RowMajor import and similar in test_cython_blas with Cython 3.1 by ogrisel · Pull Request #31301 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

Fix BLAS_Order.RowMajor import and similar in test_cython_blas with Cython 3.1 #31301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 5, 2025
Merged

Fix BLAS_Order.RowMajor import and similar in test_cython_blas with Cython 3.1 #31301

merged 1 commit into from
May 5, 2025

Conversation

ogrisel
Copy link
Member
@ogrisel ogrisel commented May 5, 2025 •
edited
Loading

Follow-up on #31263.

Fixes #31296, #31284, #31283, #31269.

@github-actions GitHub Actions
Copy link
github-actions bot commented May 5, 2025

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 1f90453. Link to the linter CI: here

@ogrisel ogrisel mentioned this pull request May 5, 2025
Closed
@ogrisel
Copy link
Member Author
ogrisel commented May 5, 2025 •
edited
Loading

Since the bug only impacts scikit-learn binaries built with Cython 3.1, there is probably no need to backport this fix to the 1.6 branch (unless we want to build a release a new scikit-learn 1.6.2 release with Cython 3.1 for some other reason than this bug).

jeremiedbb
jeremiedbb approved these changes May 5, 2025
View reviewed changes
Copy link
Member
@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Did you find a reason why it was valid before and now it's not documented somewhere ?

@jeremiedbb
Copy link
Member

It has to do with import vs cimport because there are other places where we cimport these enum values directly and it works fine. I'm okay with this workaround but that's an odd behavior from cython.

@ogrisel ogrisel merged commit 2d66fd7 into scikit-learn:main May 5, 2025
47 of 48 checks passed
@ogrisel ogrisel deleted the fix-test_cython_blas branch May 5, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an accoun 6303 t? Sign in to comment
Reviewers

@jeremiedbb jeremiedbb jeremiedbb approved these changes

Assignees
No one assigned
Labels
module:utils No Changelog Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ogrisel @jeremiedbb
0