8000 :lock: :robot: CI Update lock files for scipy-dev CI build(s) :lock: :robot: by scikit-learn-bot · Pull Request #31296 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

🔒 🤖 CI Update lock files for scipy-dev CI build(s) 🔒 🤖 #31296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 5, 2025
Merged

🔒 🤖 CI Update lock files for scipy-dev CI build(s) 🔒 🤖 #31296

merged 3 commits into from
May 5, 2025

Conversation

scikit-learn-bot
Copy link
Contributor

Update lock files.

Note

If the CI tasks fail, create a new branch based on this PR and add the required fixes to that branch.

@github-actions GitHub Actions
Copy link
github-actions bot commented May 5, 2025 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: fa0a303. Link to the linter CI: here

@betatim
Copy link
Member
betatim commented May 5, 2025 •
edited
Loading

This failure looks like it is similar to what #31263 tried to fix last week. I don't know enough about how _cython_blas.pxd works to understand what has changed recently to lead to the failure (how could the import like from sklearn.utils._Cython_blas import ColMajor ever work? Shouldn't it involve BLAS_Order?)

@ogrisel
Copy link
Member
ogrisel commented May 5, 2025

Yes I agree, the test file should have been updated as well. Let me open a PR.

@ogrisel ogrisel mentioned this pull request May 5, 2025
Merged
@jeremiedbb jeremiedbb reopened this May 5, 2025
@ogrisel ogrisel enabled auto-merge (squash) May 5, 2025 12:39
@ogrisel ogrisel merged commit 4f614da into scikit-learn:main May 5, 2025
37 checks passed
@betatim
Copy link
Member
81D3 betatim commented May 5, 2025

Thanks! I hadn't thought of the option of the test being out of date and instead started wondering what python trick I don't know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

Assignees
No one assigned
Labels
Build / CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@scikit-learn-bot @betatim @ogrisel @jeremiedbb @web-flow
0