8000 MNT Keep bumping min Python version to 3.10 by DimitriPapadopoulos · Pull Request #31024 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

MNT Keep bumping min Python version to 3.10 #31024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2025
Merged

MNT Keep bumping min Python version to 3.10 #31024

merged 1 commit into from
Mar 20, 2025

Conversation

DimitriPapadopoulos
Copy link
Contributor

Reference Issues/PRs

Follow-up of #30895.

Fixes #31020.

See also #31016.

What does this implement/fix? Explain your changes.

The Python version currently needs to be updated in multiple places.

Any other comments?

@github-actions GitHub Actions
Copy link

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: fca8de9. Link to the linter CI: here

@DimitriPapadopoulos DimitriPapadopoulos mentioned this pull request Mar 19, 2025
Merged
@lesteve
Copy link
Member
lesteve commented Mar 20, 2025

Merging this one, thanks a lot!

@lesteve lesteve merged commit 0fb9e8c into scikit-learn:main Mar 20, 2025
36 checks passed
@DimitriPapadopoulos DimitriPapadopoulos deleted the check-sdist branch March 20, 2025 14:34
@lucascolley
Copy link
Contributor

found one more place in the docs: https://scikit-learn.org/dev/developers/advanced_installation.html#runtime-dependencies

@lesteve lesteve mentioned this pull request Mar 26, 2025
Merged
@lesteve
Copy link
Member
lesteve commented Mar 26, 2025

Thanks @lucascolley! I opened #31081 to fix it hopefully.

@DimitriPapadopoulos
Copy link
Contributor Author

@lesteve Here is another one:

scikit-learn/build_tools/github/upload_anaconda.sh

Lines 15 to 17 in 0ae1c43

# Install Python 3.8 because of a bug with Python 3.9
export PATH=$CONDA/bin:$PATH
conda create -n upload -y python=3.8

@lesteve
Copy link
Member
lesteve commented Mar 26, 2025

@DimitriPapadopoulos I saw it as well at one point, feel free to open a PR for this 😉. I think doing conda create -n upload anaconda-client would probably good enough. I recently created an anaconda-client conda env and it worked fine with Python 3.13.

@DimitriPapadopoulos
Copy link
Contributor Author

@lesteve Shouldn't this paragraph be updated?

scikit-learn/README.rst

Lines 75 to 77 in 0ae1c43

**Scikit-learn 0.20 was the last version to support Python 2.7 and Python 3.4.**
scikit-learn 1.0 and later require Python 3.7 or newer.
scikit-learn 1.1 and later require Python 3.8 or newer.

The information is actually duplicated:

scikit-learn/doc/install.rst

Lines 204 to 211 in 0ae1c43

Scikit-learn 0.20 was the last version to support Python 2.7 and Python 3.4.
Scikit-learn 0.21 supported Python 3.5-3.7.
Scikit-learn 0.22 supported Python 3.5-3.8.
Scikit-learn 0.23-0.24 required Python 3.6 or newer.
Scikit-learn 1.0 supported Python 3.7-3.10.
Scikit-learn 1.1, 1.2 and 1.3 support Python 3.8-3.12
Scikit-learn 1.4 requires Python 3.9 or newer.
Scikit-learn 1.7 requires Python 3.10 or newer.

I suggest keeping a single copy of that piece of information. Which one?

This was referenced Mar 26, 2025
Merged
Merged
lucyleeow pushed a commit to lucyleeow/scikit-learn that referenced this pull request Apr 2, 2025
@DimitriPapadopoulos @lucyleeow
CI Bump Python version to 3.10 in check-sdist workflow (scikit-learn#…
5815ee5 
…31024)
@DimitriPapadopoulos DimitriPapadopoulos mentioned this pull request Apr 3, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesteve lesteve lesteve approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

⚠️ CI failed on Check sdist (last failure: Mar 20, 2025) ⚠️
3 participants
@DimitriPapadopoulos @lesteve @lucascolley
0