8000 MNT Get rid of yet another reference to Python 3.8 by DimitriPapadopoulos · Pull Request #31083 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

MNT Get rid of yet another reference to Python 3.8 #31083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 27, 2025
Merged

MNT Get rid of yet another reference to Python 3.8 #31083

merged 1 commit into from
Mar 27, 2025

Conversation

DimitriPapadopoulos
Copy link
Contributor

Reference Issues/PRs

Fix issue reported in #31024 (comment).

What does this implement/fix? Explain your changes.

We shouldn't need python here, anaconda-client seems good enough.

Any other comments?

@DimitriPapadopoulos
MNT Get rid of yet another reference to Python 3.8
32b3ec4 
We shouldn't need python here, anaconda-client seems good enough.
@github-actions GitHub Actions
Copy link

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 32b3ec4. Link to the linter CI: here

lesteve
lesteve approved these changes Mar 27, 2025
View reviewed changes
Copy link
Member
@lesteve lesteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This PR is not testing anything since this script only runs on schedule in main. I did create recently a Python 3.13 with anaconda-client and uploaded fine a file to anaconda.org.

I also don't expect a need to conservatively pin Python.

@lesteve lesteve enabled auto-merge (squash) March 27, 2025 03:45
@lesteve lesteve merged commit 3550ebb into scikit-learn:main Mar 27, 2025
37 checks passed
@DimitriPapadopoulos DimitriPapadopoulos deleted the anaconda_3.8 branch March 27, 2025 08:11
lucyleeow pushed a commit to lucyleeow/scikit-learn that referenced this pull request Apr 2, 2025
@DimitriPapadopoulos @lucyleeow
MNT Get rid of yet another reference to Python 3.8 (scikit-learn#31083)
e9bda45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesteve lesteve lesteve approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DimitriPapadopoulos @lesteve
0