10000 DOC Fix Python min version in advanced installation docs by DimitriPapadopoulos · Pull Request #31139 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

DOC Fix Python min version in advanced installation docs #31139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

DOC Fix Python min version in advanced installation docs #31139

wants to merge 2 commits into from

Conversation

DimitriPapadopoulos
Copy link
Contributor
@DimitriPapadopoulos DimitriPapadopoulos commented Apr 3, 2025 •
edited
Loading

Reference Issues/PRs

Follow-up of #30895, #31024, #31081, etc.

What does this implement/fix? Explain your changes.

Use |PythonMinVersion| instead of hard-coding Python minimum version.

Any other comments?

@github-actions GitHub Actions
Copy link
github-actions bot commented Apr 3, 2025 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 5f56b17. Link to the linter CI: here

@jeremiedbb
Copy link
Member
jeremiedbb commented Apr 3, 2025 •
edited
Loading

That was already done in #31081.
I updated your branch from main because I was not seing things that I knew should be there. It looks like you're branching out of an old version of main. As you can see the diff is now empty meaning that your change is already in main. I'm going to close this one.

@jeremiedbb jeremiedbb closed this Apr 3, 2025
@DimitriPapadopoulos
Copy link
Contributor Author

Yet I ran git pull upstream main this morning. It could be that my local repository is corrupted.

@jeremiedbb
Copy link
Member

You can try to reset your local main branch to be identical to the upstream main branch

git checkout main
git fetch upstream
git reset --hard upstream/main

Usually what I do before creating a new branch is

git checkout main
git fetch upstream
git rebase upstream/main
git checkout -b my_branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DimitriPapadopoulos @jeremiedbb
0