MNT fix error message for UnsetMetadataPassedError in validation #31014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrinjalali
reviewed
Mar 22, 2025
Comment on lines
-389
to
-392
| " want to use and `metadata=False` for not using it. See the" | ||
| " Metadata Routing User guide" | ||
| " <https://scikit-learn.org/stable/metadata_routing.html> for more" | ||
| " information." |
There was a problem hiding this comment.
note that if you think we can add this part to the error message for others in general (which I think is now missing) I'd be happy about that too.
StefanieSenger
commented
Mar 24, 2025
| @@ -1184,7 +1173,7 @@ def cross_val_predict( | |||
| # methods. For these router methods, we create the router to use | |||
| # `process_routing` on it. | |||
| router = ( | |||
| MetadataRouter(owner="cross_validate") | |||
| MetadataRouter(owner="cross_val_predict") | |||
There was a problem hiding this comment.
Correction of owner-string. Unrelated to this PR.
adrinjalali
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes error message in the validation module.
closes #30818
follow-up fix for #28517 and #28056