8000 ENH Improved error messages for `UnsetMetadataPassedError` by StefanieSenger · Pull Request #28056 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

ENH Improved error messages for UnsetMetadataPassedError #28056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 5, 2024
Merged

ENH Improved error messages for UnsetMetadataPassedError #28056

merged 5 commits into from
Jan 5, 2024

Conversation

StefanieSenger
Copy link
Contributor

This PR suggests to improve the error messages from UnsetMetadataPassedError for the cross validation functions.

It's now mentioning the estimator, on which the set_fit_request() method needs to be called and how.

@github-actions GitHub Actions
Copy link
github-actions bot commented Jan 3, 2024 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 487dd24. Link to the linter CI: here

thomasjpfan
thomasjpfan approved these changes Jan 5, 2024
View reviewed changes
Copy link
Member
@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment, otherwise LGTM.

@StefanieSenger
Copy link
Contributor Author

Thanks for reviewing, @thomasjpfan. :-) I've made the little change as requested.

@adrinjalali adrinjalali merged commit 34061da into scikit-learn:main Jan 5, 2024
@StefanieSenger StefanieSenger deleted the UnsetMetadataPassedError branch January 5, 2024 13:37
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Feb 10, 2024
@StefanieSenger @glemaitre
ENH Improved error messages for UnsetMetadataPassedError (scikit-le…
1b9f778 
…arn#28056)
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Feb 13, 2024
@StefanieSenger @glemaitre
ENH Improved error messages for UnsetMetadataPassedError (scikit-le…
c083854 
…arn#28056)
glemaitre pushed a commit that referenced this pull request Feb 13, 2024
@StefanieSenger @glemaitre
ENH Improved error messages for UnsetMetadataPassedError (#28056)
4ec54b8
@StefanieSenger StefanieSenger mentioned this pull request Mar 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrinjalali adrinjalali adrinjalali approved these changes

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees
No one assigned
Labels
module:model_selection No Changelog Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@StefanieSenger @adrinjalali @thomasjpfan
0