FIX: Fix for binary classifier prediction shape in partial dependence function #30287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glemaitre
reviewed
Nov 18, 2024
There was a problem hiding this comment.
The fix looks good.
I'll add this PR in the milestone to make sure that we backport to not release the bug in 1.6 final.
Thanks @stephenpardy
doc/whats_new/upcoming_changes/sklearn.inspection/302871.fix.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Guillaume Lemaitre <guillaume@probabl.ai>
…m/stephenpardy/scikit-learn into 30271-partial-dependence-grid-fix
|
Looks like my other PR #26202 which also included the fix was merged today. |
|
Indeed so I guess we can close this one. It seems like #26202 included a non-regression test, for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #30271
What does this implement/fix? Explain your changes.
Removes code that selects the positive class in the partial dependence function - the positive class is already selected by
_get_response_valuesAny other comments?
Changes pulled from #26202