10000 ENH Add custom_range argument for partial dependence - version 2 by stephenpardy · Pull Request #26202 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

ENH Add custom_range argument for partial dependence - version 2 #26202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 87 commits into from
Nov 19, 2024
Merged

ENH Add custom_range argument for partial dependence - version 2 #26202

merged 87 commits into from
Nov 19, 2024

Conversation

stephenpardy
Copy link
Contributor
@stephenpardy stephenpardy commented Apr 17, 2023 •
edited
Loading

Reference Issues/PRs

Fixes #20890 and is a followup to the stale PR - #21033

Also fixes #30271

What does this implement/fix? Explain your changes.

This PR allows users to specify a custom_range of values to calculate partial depedency for some or all of the features.

The api is custom_range={feature: array-like of grid values}.

Any other comments?

@glemaitre
Copy link
Member

We will not make it for 1.6. I moving the milestone to 1.7

@glemaitre glemaitre modified the milestones: 1.6, 1.7 Nov 6, 2024
adrinjalali
adrinjalali reviewed Nov 7, 2024
View reviewed changes
Copy link
Member
@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are also failing.

stephenpardy and others added 6 commits November 7, 2024 08:13
@stephenpardy @adrinjalali
Update doc/whats_new/upcoming_changes/sklearn.inspection/26202.enhanc…
be26fcb 
…ement.rst

Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
@stephenpardy @adrinjalali
Update examples/inspection/plot_partial_dependence.py
f903523 
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
@stephenpardy @adrinjalali
Update examples/inspection/plot_partial_dependence.py
d7e4673 
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
@stephenpardy @adrinjalali
Update examples/inspection/plot_partial_dependence.py
dd741ed 
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
@stephenpardy @adrinjalali
Update sklearn/inspection/_partial_dependence.py
97a7535 
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
@stephenpardy
Merge branch 'main' into 20890-partial-dependence-custom-grid
a335260
@stephenpardy
Copy link
Contributor Author

Tests are also failing.

Thanks for the suggestions, I haven't had much time to look at this recently. I will also update the version number to specify 1.7.

@stephenpardy stephenpardy mentioned this pull request Nov 13, 2024
Closed
@stephenpardy
Copy link
Contributor Author

@adrinjalali I think I have addressed all your comments. I have fixed a separate issue here, but can split that out if desired.

@stephenpardy stephenpardy mentioned this pull request Nov 16, 2024
Closed
@adrinjalali adrinjalali merged commit 17ab8c0 into scikit-learn:main Nov 19, 2024
30 checks passed
@lesteve lesteve mentioned this pull request Jan 20, 2025
Open
@ogrisel ogrisel mentioned this pull request Mar 4, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrinjalali adrinjalali adrinjalali approved these changes

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees
No one assigned
Labels
module:inspection
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.

partial_dependence errors when given only two grid points Allow users to pass their own grid to partial dependence
7 participants
@stephenpardy @thomasjpfan @mayer79 @glemaitre @adrinjalali @lorentzenchr @freddyaboulton
0