8000 MAINT Parameters validation for sklearn.preprocessing.binarize by jiawei-zhang-a · Pull Request #26076 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

MAINT Parameters validation for sklearn.preprocessing.binarize #26076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2023
Merged

MAINT Parameters validation for sklearn.preprocessing.binarize #26076

merged 1 commit into from
Apr 4, 2023

Conversation

@jiawei-zhang-a
Copy link
Contributor
@jiawei-zhang-a jiawei-zhang-a commented Apr 3, 2023

Reference Issues/PRs

Towards #24862

What does this implement/fix? Explain your changes.

Automatic parameters validation for sklearn.preprocessing.binarize

Any other comments?

glemaitre
glemaitre approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member
@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @jiawei-zhang-a

@glemaitre glemaitre added No Changelog Needed Validation related to input validation labels Apr 4, 2023
jeremiedbb
jeremiedbb approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member
@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @jiawei-zhang-a

@jeremiedbb jeremiedbb merged commit 19ed2a0 into scikit-learn:main Apr 4, 2023
Veghit pushed a commit to Veghit/scikit-learn that referenced this pull request Apr 15, 2023
@jiawei-zhang-a
MAINT Parameters validation for sklearn.preprocessing.binarize (sciki…
8cfa68e 
…t-learn#26076)
MohitBurkule added a commit to MohitBurkule/scikit-learn that referenced this pull request May 7, 2023
@MohitBurkule @jeremiedbb
@Micky774 @jjerphan @ogrisel @ZeeshanLone @adrinjalali @Shivachauhan17 @AymericBasset @marenwestermann @choudharynishu @glemaitre @lesteve @hbenedek @pooja-subramaniam @rusdes @yuanx749 @OmarManzoor @2357juan @thomasjpfan @amueller @jovan-stojanovic @rprkh @bharatr21 @sortofamudkip @glevv @lorentzenchr @awinml @Veghit @precondition @marctorsoc @DominicFox @futurewarning @Charlie-XIAO @joseortiz3 @betatim @ChVeen @adienes @dberenbaum @lene @A-H-Mansoury @Lothiraldan @pinkgoldpeach @windiana42 @mdarii @murezzda @ppiont @jpangas @dmitrylala @ROMEEZHOU @ekaterinabutyugina @jiawei-zhang-a @ansamz @genvalen @BabaYaga1221 @ArturoAmorQ @rgommers @Jessicakk0711 @SinghAnkur28 @seoeunHong @xi-jiajun @dvignesh1995 @Vincent-violet @elabongaatuo @TomDLT @andreped @duttashi @philsupertramp @smith558 @hujiahong726 @AcylSilane @niuk-a @c-git @annegnx @gbolmier
merge updates (#1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@glemaitre glemaitre glemaitre approved these changes

@jeremiedbb jeremiedbb jeremiedbb approved these changes

Assignees

No one assigned

Labels

module:preprocessing No Changelog Needed Validation related to input validation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jiawei-zhang-a @glemaitre @jeremiedbb
0