MAINT Parameters validation for datasets.make_blobs #25983

ghost · 2023-03-27T19:23:51Z

aizardar

sklearn/datasets/_samples_generator.py

sklearn/tests/test_public_functions.py

jeremiedbb

sklearn/datasets/_samples_generator.py

glemaitre · 2023-03-29T16:22:16Z

sklearn/datasets/_samples_generator.py

            raise ValueError(
                "Length of `n_samples` not consistent with number of "
                f"centers. Got n_samples = {n_samples} and centers = {centers}"
-            ) from e
+            )
        else:


Here we used a try ... except ... else. So now we don't need this else anymore and we can unindent the 2 remaining lines.

That makes sense, I got confused there, thanks! Should be good now.

glemaitre

jeremiedbb

add parameters validation to datasets.make_blobs

0059759

github-actions bot added the module:datasets label Mar 27, 2023

aizardar approved these changes Mar 28, 2023

View reviewed changes

glemaitre added Validation related to input validation No Changelog Needed labels Mar 29, 2023

glemaitre self-requested a review March 29, 2023 08:42

Merge branch 'main' into parameters_validation_make_blobs

e3772f5

glemaitre reviewed Mar 29, 2023

View reviewed changes

sklearn/datasets/_samples_generator.py Show resolved Hide resolved

glemaitre reviewed Mar 29, 2023

View reviewed changes

sklearn/tests/test_public_functions.py Outdated Show resolved Hide resolved

Update sklearn/tests/test_public_functions.py

160806c

jeremiedbb reviewed Mar 29, 2023

View reviewed changes

sklearn/datasets/_samples_generator.py Show resolved Hide resolved

Théophile Baranger added 2 commits March 29, 2023 12:08

update centers type to array-like in docstring

6bcaf39

remove try except to improve readability

f23cd90

glemaitre reviewed Mar 29, 2023

View reviewed changes

remove redundant else and unindent block

a32c13b

glemaitre approved these changes Mar 30, 2023

View reviewed changes

jeremiedbb approved these changes Mar 30, 2023

View reviewed changes

jeremiedbb merged commit 27cf2dd into scikit-learn:main Mar 30, 2023

ghost deleted the parameters_validation_make_blobs branch March 31, 2023 19:02

Veghit pushed a commit to Veghit/scikit-learn that referenced this pull request Apr 15, 2023

MAINT Parameters validation for datasets.make_blobs (scikit-learn#25983)

cf695ed

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MAINT Parameters validation for datasets.make_blobs #25983

MAINT Parameters validation for datasets.make_blobs #25983

MAINT Parameters validation for datasets.make_blobs #25983

MAINT Parameters validation for datasets.make_blobs #25983

Conversation

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment