8000 MAINT Clean deprecation for 1.2: load_boston follow-up by jeremiedbb · Pull Request #24653 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

MAINT Clean deprecation for 1.2: load_boston follow-up #24653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 13, 2022
Merged

MAINT Clean deprecation for 1.2: load_boston follow-up #24653

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ba77e91
remove load_boston references from the docs
jeremiedbb Oct 13, 2022
7035a1e
iter
jeremiedbb Oct 13, 2022
8f996cb
update poor_score
jeremiedbb Oct 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions doc/datasets/toy_dataset.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ They can be loaded using the following functions:

.. autosummary::

load_boston
load_iris
load_diabetes
load_digits
Expand All @@ -28,8 +27,6 @@ These datasets are useful to quickly illustrate the behavior of the
various algorithms implemented in scikit-learn. They are however often too
small to be representative of real world machine learning tasks.

.. include:: ../../sklearn/datasets/descr/boston_house_prices.rst

.. include:: ../../sklearn/datasets/descr/iris.rst

.. include:: ../../sklearn/datasets/descr/diabetes.rst
Expand Down
5 changes: 3 additions & 2 deletions doc/developers/develop.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -553,8 +553,9 @@ preserves_dtype (default=``[np.float64]``)

poor_score (default=False)
whether the estimator fails to provide a "reasonable" test-set score, which
currently for regression is an R2 of 0.5 on a subset of the boston housing
dataset, and for classification an accuracy of 0.83 on
currently for regression is an R2 of 0.5 on ``make_regression(n_samples=200,
n_features=10, n_informative=1, bias=5.0, noise=20, random_state=42)``, and
for classification an accuracy of 0.83 on
``make_blobs(n_samples=300, random_state=0)``. These datasets and values
are based on current estimators in sklearn and might be replaced by
something more systematic.
Expand Down
1 change: 0 additions & 1 deletion doc/modules/classes.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,6 @@ Loaders
datasets.fetch_rcv1
datasets.fetch_species_distributions
datasets.get_data_home
datasets.load_boston
datasets.load_breast_cancer
datasets.load_diabetes
datasets.load_digits
Expand Down
50 changes: 0 additions & 50 deletions sklearn/datasets/descr/boston_house_prices.rst
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion sklearn/datasets/tests/test_common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,6 @@ def _generate_func_supporting_param(param, dataset_type=("load", "fetch")):
@pytest.mark.parametrize(
"name, dataset_func", _generate_func_supporting_param("return_X_y")
)
@pytest.mark.filterwarnings("ignore:Function load_boston is deprecated")
def test_common_check_return_X_y(name, dataset_func):
bunch = dataset_func()
check_return_X_y(bunch, dataset_func)
Expand Down
0