8000 MAINT Clean deprecation for 1.2: load_boston follow-up by jeremiedbb · Pull Request #24653 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

MAINT Clean deprecation for 1.2: load_boston follow-up #24653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 13, 2022
Merged

MAINT Clean deprecation for 1.2: load_boston follow-up #24653

merged 3 commits into from
Oct 13, 2022

Conversation

jeremiedbb
Copy link
Member
@jeremiedbb jeremiedbb commented Oct 13, 2022 •
edited
Loading

Follow-up of #24603
There are references to the dataset left in the docs

cc/ @glemaitre

thomasjpfan
thomasjpfan approved these changes Oct 13, 2022
View reviewed changes
Copy link
Member
@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jjerphan
jjerphan approved these changes Oct 13, 2022
View reviewed changes
Copy link
Member
@jjerphan jjerphan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

There is still one mention of this dataset in the documentation

Probably it makes sense adapting the description of poor_score as well?

@jeremiedbb
Copy link
Member Author

I updated the description of poor_score to reflect the actual dataset we are testing against

@jjerphan jjerphan merged commit 6818c9b into scikit-learn:main Oct 13, 2022
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Oct 31, 2022
@jeremiedbb @glemaitre
MAINT Clean deprecation for 1.2: load_boston follow-up (scikit-learn#…
274d537 
…24653)

* remove load_boston references from the docs

* iter

* update poor_score
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasjpfan thomasjpfan thomasjpfan approved these changes

@jjerphan jjerphan 5445 jjerphan approved these changes

Assignees
No one assigned
Labels
module:datasets No Changelog Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jeremiedbb @thomasjpfan @jjerphan @lesteve
0