8000 MAINT Bump min dependencies for 1.2 by jeremiedbb · Pull Request #24650 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

MAINT Bump min dependencies for 1.2 #24650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Oct 14, 2022
Merged

MAINT Bump min dependencies for 1.2 #24650

merged 12 commits into from
Oct 14, 2022

Conversation

jeremiedbb
Copy link
Member
@jeremiedbb jeremiedbb commented Oct 13, 2022 •
edited
Loading

Closes #24401

  • bump min dependencies
  • re-generate lock files
  • remove fixes that are now unnecessary

So it turns out that bumping scipy to 1.4 would mean that we drop the support for the scipy installed with the system Python on Ubuntu 20.04. Since the next LTS is Ubuntu 22.04 and is quite recent (april 2022), it might be good to be a bit conservative here. Also, the Python coming with Ubuntu 20.04 is 3.8 for which we will drop support for scikit-learn 1.3, so we won't have the dilemma anymore by then.

@jeremiedbb jeremiedbb added this to the 1.2 milestone Oct 13, 2022
@jeremiedbb jeremiedbb mentioned this pull request Oct 13, 2022
Closed
@ogrisel
Copy link
Member
ogrisel commented Oct 13, 2022

test_min_dependencies_readme :)

jjerphan
jjerphan 8000 approved these changes Oct 14, 2022
View reviewed changes
Copy link
Member
@jjerphan jjerphan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if the CI runs are green.

@ogrisel ogrisel merged commit 6697de3 into scikit-learn:main Oct 14, 2022
@jeremiedbb jeremiedbb mentioned this pull request Oct 14, 2022
Closed
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Oct 31, 2022
@jeremiedbb @jjerphan @glemaitre
MAINT Bump min dependencies for 1.2 (scikit-learn#24650)
66a1b8b 
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

@jjerphan jjerphan jjerphan approved these changes

Assignees
No one assigned
Labels
module:manifold module:utils No Changelog Needed
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.

RFC bump up dependencies for 1.2
3 participants
@jeremiedbb @ogrisel @jjerphan
0