8000 Remove sklearn.utils.fixes.loguniform for 1.3 release · Issue #23699 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

Remove sklearn.utils.fixes.loguniform for 1.3 release #23699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lesteve opened this issue Jun 20, 2022 · 5 comments · Fixed by #24665
Closed

Remove sklearn.utils.fixes.loguniform for 1.3 release #23699

lesteve opened this issue Jun 20, 2022 · 5 comments · Fixed by #24665
Labels
module:utils
Milestone
1.3

Comments

@lesteve
Copy link
Member
lesteve commented Jun 20, 2022 •
edited
Loading

scipy.stats.loguniform is a thing since scipy 1.4, see
scipy/scipy#10815.

According to #23637 (comment), the minimum Scipy release will be 1.6 when scikit-learn 1.2 is released.

That means sklearn.utils.fixes.loguniform can be removed, adding this issue so that we remember to do it when 1.2 release is close.
@lesteve lesteve added this to the 1.2 milestone Jun 20, 2022
@github-actions github-actions bot added the Needs Triage Issue requires triage label Jun 20, 2022
@glemaitre glemaitre added help wanted and removed Needs Triage Issue requires triage labels Jun 20, 2022
@glemaitre
Copy link
Member

I am adding the "help wanted" tag.

@lesteve lesteve mentioned this issue Jun 21, 2022
Merged
@MaxwellLZH MaxwellLZH mentioned this issue Jun 22, 2022
Closed
@brgopalakrishnan
Copy link

/take

@lesteve
Copy link
Member Author
lesteve commented Jul 6, 2022

@brgopalakrishnan sorry there is already a PR on this one, feel free to look for another issue to work on!

I guess we should have removed the help wanted label ...

@brgopalakrishnan
Copy link
brgopalakrishnan commented Jul 6, 2022 •
edited
Loading

@lesteve Thank you for the update. Just curious, I see only the same in grid_search.rst line number 152. Is that the one supposed to be removed.?

@jeremiedbb jeremiedbb mentioned this issue Sep 8, 2022
Closed
@jeremiedbb
Copy link
Member

We finally decided to be conservative and keep scipy min version = 1.3.3 for one more version (reasons explained in #24650), so we need to keep the backport in the mean time unfortunately. I'm moving it to the 1.3 milestone

@jeremiedbb jeremiedbb modified the milestones: 1.2, 1.3 Oct 14, 2022
@betatim betatim mentioned this issue Oct 14, 2022
Merged
@jeremiedbb jeremiedbb changed the title Remove sklearn.utils.fixes.loguniform for 1.2 release Remove sklearn.utils.fixes.loguniform for 1.3 release Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
module:utils
Projects
None yet
Milestone
1.3
5 participants
@cmarmo @lesteve @glemaitre @brgopalakrishnan @jeremiedbb
0