8000 [MRG] DOC added link to linkcheck_ignore by Eschivo · Pull Request #23739 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

[MRG] DOC added link to linkcheck_ignore #23739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 24, 2022
Merged

[MRG] DOC added link to linkcheck_ignore #23739

merged 2 commits into from
Jun 24, 2022

Conversation

Eschivo
Copy link
Contributor
@Eschivo Eschivo commented Jun 23, 2022

Reference Issues/PRs

#23631

What does this implement/fix? Explain your changes.

The link https://doi.org/10.13140/RG.2.2.35280.02565 in _spectral.py is actually working. Added to linkcheck_ignore in conf.py

@Eschivo
Added link to linkcheck_ignore
31e7a5e 
Added link referring to spectral_clustering in _spectral.py in
linkcheck_ignore
@lesteve
Copy link
Member
lesteve commented Jun 23, 2022

I think you should add the doi.org to linkcheck_ignore but not 100% sure. To be sure you can try to run make linkcheck from the doc folder locally.

@Eschivo
Copy link
Contributor Author
Eschivo commented Jun 23, 2022

Thank you @lesteve, but actually I'm unable to run the make command, on Windows PowerShell I get this error message:

PS C:\Users\eliaa\Documents\GitHub\scikit-learn\doc> .\make
Running Sphinx v5.0.2

Configuration error:
There is a programmable error in your configuration file:

Traceback (most recent call last):
  File "c:\python38\lib\site-packages\sphinx\config.py", line 343, in eval_config_file
    exec(code, namespace)
  File "C:\Users\eliaa\Documents\GitHub\scikit-learn\doc\conf.py", line 18, in <module>
    from sklearn.externals._packaging.version import parse
ModuleNotFoundError: No module named 'sklearn'

That is pretty funny since I'm working in the sklearn repo. Do you have any hint on how I can get rid of this? I tried searching online but I didn't find anything useful...sorry to bother you

@Eschivo
Copy link
Contributor Author
Eschivo commented Jun 23, 2022

Thank you @lesteve, but actually I'm unable to run the make command, on Windows PowerShell I get this error message:

PS C:\Users\eliaa\Documents\GitHub\scikit-learn\doc> .\make
Running Sphinx v5.0.2

Configuration error:
There is a programmable error in your configuration file:

Traceback (most recent call last):
  File "c:\python38\lib\site-packages\sphinx\config.py", line 343, in eval_config_file
    exec(code, namespace)
  File "C:\Users\eliaa\Documents\GitHub\scikit-learn\doc\conf.py", line 18, in <module>
    from sklearn.externals._packaging.version import parse
ModuleNotFoundError: No module named 'sklearn'

That is pretty funny since I'm working in the sklearn repo. Do you have any hint on how I can get rid of this? I tried searching online but I didn't find anything useful...sorry to bother you

Solved. It turned out that the build didn't go well when I first ran it. Now the command is running correctly

@Eschivo
Copy link
Contributor Author
Eschivo commented Jun 23, 2022

At the end of day you were right, gonna fix it tomorrow :)

@lesteve lesteve mentioned this pull request Jun 24, 2022
Closed
34 tasks
@lesteve
Copy link
Member
lesteve commented Jun 24, 2022

I solved the conflicts and pushed a minor tweak into your branch, thanks a lot, merging!

General advice: create a branch to create a pull request from, rather than using your main branch. You can look at https://docs.github.com/en/get-started/quickstart/github-flow#create-a-branch for more details.

@lesteve lesteve merged commit b2430bb into scikit-learn:main Jun 24, 2022
@Eschivo
Copy link
Contributor Author
Eschivo commented Jun 24, 2022

Thank you @lesteve ! Yes, I know, my bad 😅

ogrisel pushed a commit to ogrisel/scikit-learn that referenced this pull request Jul 11, 2022
@Eschivo @lesteve @ogrisel
MNT Added link to linkcheck_ignore (scikit-learn#23739)
246851c 
Co-authored-by: Loïc Estève <loic.esteve@ymail.com>
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Aug 4, 2022
@Eschivo @lesteve @glemaitre
MNT Added link to linkcheck_ignore (scikit-learn#23739)
61bb2bd 
Co-authored-by: Loïc Estève <loic.esteve@ymail.com>
glemaitre pushed a commit that referenced this pull request Aug 5, 2022
@Eschivo @lesteve @glemaitre
MNT Added link to linkcheck_ignore (#23739)
f375422 
Co-authored-by: Loïc Estève <loic.esteve@ymail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Eschivo @lesteve
0