8000 DOC fix link "Comparison of model selection for regression" by Eschivo · Pull Request #23736 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]

Skip to content

DOC fix link "Comparison of model selection for regression" #23736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 23, 2022

Conversation

Eschivo
Copy link
Contributor
@Eschivo Eschivo commented Jun 23, 2022

Reference Issues/PRs

Towards #23631

What does this implement/fix? Explain your changes.

Fix broken link to `Cherkassky, Vladimir, and Yunqian Ma.
"Comparison of model selection for regression."
Neural computation 15.7 (2003): 1691-1714.

Any other comments?

Fix broken link 13
`Cherkassky, Vladimir, and Yunqian Ma.
"Comparison of model selection for regression."
Neural computation 15.7 (2003): 1691-1714.
@Eschivo
Copy link
Contributor Author
Eschivo commented Jun 23, 2022

@lesteve I've also made a PR here #23551 with some documentation improvements that I think could be valuable for a newcomer. If you have time can you take a look or assign a reviewer? Thank you

@lesteve
Copy link
Member
lesteve commented Jun 23, 2022

Thinking about it the link I used is the one for a preprint which is not exactly the same as the published article e.g. equation numbering or figure inline or at the end. Not sure which one to use ...

@Eschivo
Copy link
Contributor Author
Eschivo commented Jun 23, 2022

Your link is more accessible than mine but has poor formatting with respect to the other. If you think that accessibility has priority go with yours

@lesteve
Copy link
Member
lesteve commented Jun 23, 2022

I went for :doi: directive which redirects to the institutional website (behind a paywall)

@lesteve
Copy link
Member
lesteve commented Jun 23, 2022

I'll check the rendering of the documentation and merge if it looks OK

@lesteve
Copy link
Member
lesteve commented Jun 23, 2022

The rendering looks good locally, merging this one, thanks a lot!

@lesteve lesteve changed the title [MRG] DOC Fix broken link "Comparison of model selection for regression." DOC fix link "Comparison of model selection for regression" Jun 23, 2022
@lesteve lesteve merged commit e88cf7c into scikit-learn:main Jun 23, 2022
ogrisel pushed a commit to ogrisel/scikit-learn that referenced this pull request Jul 11, 2022
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Aug 4, 2022
glemaitre pushed a commit that referenced this pull request Aug 5, 2022
Co-authored-by: Loïc Estève <loic.esteve@ymail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0