10000 DOC fix broken link Sequential Karhunen-Loeve Transform by aman1971 · Pull Request #23706 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

DOC fix broken link Sequential Karhunen-Loeve Transform #23706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 21, 2022
Merged

DOC fix broken link Sequential Karhunen-Loeve Transform #23706

merged 5 commits into from
Jun 21, 2022

Conversation

aman1971
Copy link
Contributor
@aman1971 aman1971 commented Jun 21, 2022 •
edited
Loading

Reference Issues/PRs

Partially fix #23631

What does this implement/fix? Explain your changes.

Fix link:
https://www.cs.technion.ac.il/~mic/doc/skl-ip.pdf

Any other comments?

@lesteve
Copy link
Member
lesteve commented Jun 21, 2022

I did not know academia.edu before this PR, it seems like you need to be logged in to access the link you used though: https://www.academia.edu/download/53866475/83.85543220170715-8581-fehoxf.pdf

I am wondering whether we should use the official link even if it is behind a paywall: https://ieeexplore.ieee.org/document/855432.

@glemaitre
Copy link
Member

I think that we can use the doi instead. I will make a proposal to change the line of code.

@glemaitre glemaitre changed the title fix broken link Sequential Karhunen-Loeve Transform DOC fix broken link Sequential Karhunen-Loeve Transform Jun 21, 2022
@aman1971
Copy link
Contributor Author

I have made changes as suggested by @glemaitre

glemaitre
glemaitre approved these changes Jun 21, 2022
View reviewed changes
Copy link
Member
@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kanissh
Copy link
Contributor
kanissh commented Jun 21, 2022

@glemaitre @aman1971 There is a pdf of the paper in the author's google scholar site which is accessible, please check whether it can be used

https://scholar.google.com/citations?view_op=view_citation&hl=en&user=84bC7xgAAAAJ&citation_for_view=84bC7xgAAAAJ:u-x6o8ySG0sC

@glemaitre
Copy link
Member

@kanissh The PDF is from academia as stated by @lesteve

@kanissh
Copy link
Contributor
kanissh commented Jun 21, 2022

The problem is the source of the pdf? I get it.

@lesteve
Copy link
Member
lesteve commented Jun 21, 2022

The DOI renders fine now, merging this one.

FWIW seems like academic.edu on the Google Scholar page creates a temporary valid (notes the Expires= in th URL) link like:
https://d1wqtxts1xzle7.cloudfront.net/53866475/83.85543220170715-8581-fehoxf-with-cover-page-v2.pdf?Expires=1655817712&Signature=EmuQtNx4hfSvC7pHjrWYehUPxa5ALElZgtKiNxGdzoQO7pvZewyvUgOJedPemNaPxoeH36xK-50YlzzT-822ZwDWAgm7fovI3yElCnWYiiJmwpY25S5XiRCYT8SUYicTGbli2gO2bbxbRpCdIRvAA2HoatNb27HFr1tDzRnB70PPejpIM-fCxIhYAFh~HN~i8Iek53XISto4tYaZIwSYhWtsypOvCiKKYdDB9~OE6YBrlT9wq0xZUPGCN9SLSOINoexjyLngMSn9mapz7RnoynQFRPRilLIDQ8qJGjl0yFKUFwkqcIdUeL4sj88lbHksrfBhP-rIfQuXWHnyTuYfmg__&Key-Pair-Id=APKAJLOHF5GGSLRBV4ZA

so this is not really usable as a stable link.

@lesteve lesteve merged commit 25b5363 into scikit-learn:main Jun 21, 2022
ogrisel pushed a commit to ogrisel/scikit-learn that referenced this pull request Jul 11, 2022
@aman1971 @lesteve @ogrisel
DOC fix broken link Sequential Karhunen-Loeve Transform (scikit-learn…
e35e4a3 
…#23706)

Co-authored-by: Loïc Estève <loic.esteve@ymail.com>
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Aug 4, 2022
@aman1971 @lesteve @glemaitre
DOC fix broken link Sequential Karhunen-Loeve Transform (scikit-learn…
3e54863 
…#23706)

Co-authored-by: Loïc Estève <loic.esteve@ymail.com>
glemaitre pushed a commit that referenced this pull request Aug 5, 2022
@aman1971 @lesteve @glemaitre
DOC fix broken link Sequential Karhunen-Loeve Transform (#23706)
99d5586 
Co-authored-by: Loïc Estève <loic.esteve@ymail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glemaitre glemaitre glemaitre approved these changes

Assignees
No one assigned
Labels
Documentation module:decomposition
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix broken links in the documentation
4 participants
@aman1971 @lesteve @glemaitre @kanissh
0