fixed issue ##23631 donate link for numfocus.org #23663
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR, this is the link we want to use: https://numfocus.org/donate-to-scikit-learn (we are already in the button below). Also it would be great to remove the sentence about Paypal since that is not accurate, the button below is using NumFocus and not Paypal. Small tip for your next PR: it is best practice to use a separate branch than main to create your PR from. For example, see elsewhencode/project-guidelines#11-some-git-rules |
34 tasks
|
This has been tackled in #23695, closing this one. Sorry for this @bkhanal4351, there are other links to fix in the original issue if you feel like it 😉! |
|
@bkhanal4351 I'm really sorry for this 😞. Will be mindful in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
#23631
What does this implement/fix? Explain your changes.
fixed the broken link to nums.org Donate page line 596 doc/about.rst
Any other comments?