8000 Fixes Robust Regression Example Link From UCLA issue #23631 by wildwoodwaltz · Pull Request #23660 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

Fixes Robust Regression Example Link From UCLA issue #23631 #23660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 21, 2022
Merged

Fixes Robust Regression Example Link From UCLA issue #23631 #23660

merged 4 commits into from
Jun 21, 2022

Conversation

wildwoodwaltz
Copy link
Contributor

Reference Issues/PRs

Fix broken links in the documentation #23631

What does this implement/fix? Explain your changes.

Fixes http://www.ats.ucla.edu/stat/r/dae/rreg.html broken link in modules/linear_model.rst

by replacing this link with

https://stats.oarc.ucla.edu/stata/dae/robust-regression/

Any other comments?

Super excited to be a contributor to this, especially as a first time contributor. I love scikit-learn

@lesteve
Copy link
Member
lesteve commented Jun 17, 2022

Thanks for your PR!

It seems like the text in our documentation mention the R implementation but the link you found is mostly about Stata, which is a different language.

Small tip for your next PR: it is best practice to use a separate branch than main to create your PR from. For example, see https://github.com/elsewhencode/project-guidelines#11-some-git-rules

@lesteve
Copy link
Member
lesteve commented Jun 17, 2022 •
edited
Loading

I think this is the link we want to use: https://stats.oarc.ucla.edu/r/dae/robust-regression/

It seems very similar to a older version of the link in the web.archive.org website https://web.archive.org/web/20160214011330/http://statistics.ats.ucla.edu/stat/r/dae/rreg.htm

@lesteve lesteve mentioned this pull request Jun 20, 2022
Closed
34 tasks
@wildwoodwaltz
Copy link
Contributor Author

I have corrected the link, I shouldn't have second guessed myself. I wasn't paying close attention to the link URL. I had originally found that one.

@lesteve
Copy link
Member
lesteve commented Jun 21, 2022

Merging, thanks a lot!

@lesteve lesteve merged commit 30d8700 into scikit-learn:main Jun 21, 2022
ogrisel pushed a commit to ogrisel/scikit-learn that referenced this pull request Jul 11, 2022
@wildwoodwaltz @ogrisel
DOF fix robust regression example link (scikit-learn#23660)
4cd34e5
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Aug 4, 2022
@wildwoodwaltz @glemaitre
DOF fix robust regression example link (scikit-learn#23660)
c1b660f
glemaitre pushed a commit that referenced this pull request Aug 5, 2022
@wildwoodwaltz @glemaitre
DOF fix robust regression example link (#23660)
815082a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wildwoodwaltz @lesteve
0