8000 TST skip test_dataframe_support if matplotlib not installed by jeremiedbb · Pull Request #23322 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

TST skip test_dataframe_support if matplotlib not installed #23322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 10, 2022
Merged

TST skip test_dataframe_support if matplotlib not installed #23322

merged 1 commit into from
May 10, 2022

Conversation

jeremiedbb
Copy link
Member

follow up of #23318

The test should be skipped if matplotlib is not installed. It's not catched by the CI because it's always installed when pandas is but it was catched in #23321

@jeremiedbb jeremiedbb added To backport PR merged in master that need a backport to a release branch defined based on the milestone. No Changelog Needed Quick Review For PRs that are quick to review labels May 10, 2022
glemaitre
glemaitre approved these changes May 10, 2022
View reviewed changes
Copy link
Member
@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ogrisel ogrisel merged commit 07c1a58 into scikit-learn:main May 10, 2022
jeremiedbb added a commit to jeremiedbb/scikit-learn that referenced this pull request May 10, 2022
@jeremiedbb
skip if matplotlib not installed (scikit-learn#23322)
099a975
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

@glemaitre glemaitre glemaitre approved these changes

Assignees
No one assigned
Labels
module:inspection No Changelog Needed Quick Review For PRs that are quick to review To backport PR merged in master that need a backport to a release branch defined based on the milestone.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeremiedbb @ogrisel @glemaitre
0