8000 FIX DecisionBoundaryPlot should not raise spurious warning by glemaitre · Pull Request #23318 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

FIX DecisionBoundaryPlot should not raise spurious warning #23318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 10, 2022
Merged

FIX DecisionBoundaryPlot should not raise spurious warning #23318

merged 1 commit into from
May 10, 2022

Conversation

glemaitre
Copy link
Member

closes #23311

Recreate a dataframe on the fly in DecisionBoundaryPlot to avoid predicting on a NumPy array while the classifier have been fitted on a dataframe.

@glemaitre glemaitre added this to the 1.1 milestone May 10, 2022
@glemaitre glemaitre added the To backport PR merged in master that need a backport to a release branch defined based on the milestone. label May 10, 2022
ogrisel
ogrisel approved these changes May 10, 2022
View reviewed changes
Copy link
Member
@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming CI is green.

jeremiedbb
jeremiedbb approved these changes May 10, 2022
View reviewed changes
Copy link
Member
@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @glemaitre

@jeremiedbb jeremiedbb merged commit b0b8a39 into scikit-learn:main May 10, 2022
jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request May 10, 2022
@glemaitre @jeremiedbb
FIX DecisionBoundaryPlot should not raise spurious warning (scikit-le…
3fae010 
…arn#23318)
@jeremiedbb jeremiedbb mentioned this pull request May 10, 2022
Merged
@patrickkwang patrickkwang mentioned this pull request Mar 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

@jeremiedbb jeremiedbb jeremiedbb approved these changes

Assignees
No one assigned
Labels
module:inspection No Changelog Needed To backport PR merged in master that need a backport to a release branch defined based on the milestone.
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.

Spurious warning with DecisionBoundaryPlot
3 participants
@glemaitre @ogrisel @jeremiedbb
0