8000 CI Run all CI jobs on azure nightly by thomasjpfan · Pull Request #23118 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

CI Run all CI jobs on azure nightly #23118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 13, 2022
Merged

CI Run all CI jobs on azure nightly #23118

merged 4 commits into from
Apr 13, 2022

Conversation

thomasjpfan
Copy link
Member

Reference Issues/PRs

Related to #23110

What does this implement/fix? Explain your changes.

I think it makes sense to run all the CI jobs on azure nightly. This PR also sets the default CREATE_ISSUE_ON_TRACKER to true so that nightly errors create issues on the tracker automatically. Note that CREATE_ISSUE_ON_TRACKER is only active for nightly builds:

scikit-learn/build_tools/azure/posix.yml

Lines 82 to 83 in 28db349

condition: and(succeededOrFailed(), eq(variables['CREATE_ISSUE_ON_TRACKER'], 'true'),
eq(variables['Build.Reason'], 'Schedule'))

@jeremiedbb
Copy link
Member
jeremiedbb commented Apr 12, 2022 •
edited
Loading

I don't understand how but you managed to trigger the same failures as in #22905 (but on linux)

Edit: actually I think it's starting to pop everywhere

@thomasjpfan thomasjpfan changed the title CI Runsall CI jobs on azure nightly CI Run all CI jobs on azure nightly Apr 12, 2022
@thomasjpfan thomasjpfan mentioned this pull request Apr 12, 2022
Merged
jeremiedbb
jeremiedbb approved these changes Apr 12, 2022
View reviewed changes
Copy link
Member
@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Regardless of the outcome of #23110 I think we should enable all jobs on the azure daily job

8000

@jeremiedbb
Copy link
Member

@thomasjpfan I extracted the distutils fix into a separate PR (#23120) because it's unrelated to this PR and should be merged asap while this one might trigger some discussions

ogrisel
ogrisel approved these changes Apr 12, 2022
View reviewed changes
Copy link
Member
@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with the idea when used in conjunction with #23110 but I am not so sure about the following change:

azure-pipelines.yml
@@ -81,7 +81,6 @@ jobs:
# Tests that require large downloads over the networks are skipped in CI.
# Here we make sure, that they are still run on a regular basis.
SKLEARN_SKIP_NETWORK_TESTS: '0'
CREATE_ISSUE_ON_TRACKER: 'true'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CREATE_ISSUE_ON_TRACKER: 'true' is only set by default in posix-docker.yml, not in poxix.yml, right?

Copy link
Member Author
@thomasjpfan thomasjpfan Apr 12, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, that was a mistake. I updated the PR to set CREATE_ISSUE_ON_TRACKER to true on posix.yml as well.

@ogrisel
Copy link
Member
ogrisel commented Apr 13, 2022

Let's try this!

@ogrisel ogrisel merged commit cc6b847 into scikit-learn:main Apr 13, 2022
jjerphan pushed a commit to jjerphan/scikit-learn that referenced this pull request Apr 29, 2022
@thomasjpfan @jjerphan
CI Run all CI jobs on azure nightly (scikit-learn#23118)
483fa15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

@jeremiedbb jeremiedbb jeremiedbb approved these changes

Assignees
No one assigned
Labels
Build / CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomasjpfan @jeremiedbb @ogrisel
0