CI enable global_dtype fixture on nightly build jobs #23110
Conversation
why do you say that ? The nightly build run on all platforms |
I was incorrect and misremembered how the nightly builds work. |
|
I think the nightly on azure only run on linux with non-standard dependencies. @jeremiedbb I believe you wanted to run the tests for the nightly wheel builds: https://github.com/scikit-learn/scikit-learn/blob/main/.github/workflows/wheels.yml |
|
Oh right... @thomasjpfan you were right, I did misread the config ("ne" instead of "eq") :) |
|
Would it make sense to run all jobs in the azure config during the scheduled run ? |
I have a slight preference toward Azure so that wheel building remains simpler. But no strong opinion.
I think it makes sense to do. I opened #23118 to enable this. |
|
I am fine with either approach (Azure or the nightly wheels). As you prefer. |
|
Since the azure cron job now runs all the jobs, I think this approach is simpler since there's nothing more to do 😄 |
|
Let's merge if green to give it a try next night. |
The
globaly_dtypefixture is currently only enabled on a single CI job. It means that the float32 tests are never run on windows or macos for instance. Since enabling the fixture makes the test suite longer we don't want to do it by default, but enabling it for the nighlty build is a good compromise imo.It would also make me more comfortable with replacing some current [float64, float32] parametrization by the global_dtype fixture.