DEP loss "log" in favor of "log loss" in SGDClassifier #23046
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are some tests that still pass diff --git a/sklearn/tests/test_multioutput.py b/sklearn/tests/test_multioutput.py
index ded47c4fe..17b9bd0d7 100644
--- a/sklearn/tests/test_multioutput.py
+++ b/sklearn/tests/test_multioutput.py
@@ -257,7 +257,7 @@ def test_multi_output_classification_partial_fit():
def test_multi_output_classification_partial_fit_no_first_classes_exception():
- sgd_linear_clf = SGDClassifier(loss="log", random_state=1, max_iter=5)
+ sgd_linear_clf = SGDClassifier(loss="log_loss", random_state=1, max_iter=5)
multi_target_linear = MultiOutputClassifier(sgd_linear_clf)
msg = "classes must be passed on the first call to partial_fit."
with pytest.raises(ValueError, match=msg):Another possibility is to use the following line to find the pattern of such tests: |
jjerphan
reviewed
Apr 7, 2022
Comment on lines
+101
to
+103
| - For :class:`linear_model.SGDClassifier`, the `loss` parameter name | ||
| "log" is deprecated in favor of the new name "log_loss". | ||
| :pr:`23046` by :user:`Christian Lorentzen <lorentzenchr>`. |
There was a problem hiding this comment.
Suggested change
| - For :class:`linear_model.SGDClassifier`, the `loss` parameter name | |
| "log" is deprecated in favor of the new name "log_loss". | |
| :pr:`23046` by :user:`Christian Lorentzen <lorentzenchr>`. | |
| - For :class:`linear_model.SGDClassifier`, the `loss` parameter name | |
| `"log"` is deprecated in favor of the new name `"log_loss"`. | |
| :pr:`23046` by :user:`Christian Lorentzen <lorentzenchr>`. |
There was a problem hiding this comment.
We merged #23036 without the backticks, let's keep local consistency
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
|
@jeremiedbb Again, thanks for finishing this. |
3 tasks
jjerphan
added a commit
to jjerphan/scikit-learn
that referenced
this pull request
Apr 29, 2022
…23046) Co-authored-by: Julien Jerphanion <git@jjerphan.xyz> Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
54 tasks
eddiebergman
added a commit
to automl/auto-sklearn
that referenced
this pull request
Nov 15, 2022
rusty1s
pushed a commit
to pyg-team/pytorch_geometric
that referenced
this pull request
Mar 27, 2024
scik 8312 it-learn/scikit-learn/pull/23046 Introduces `'log_loss'` in `SGDClassifier` and deprecates `'log'`. This PR addresses this issue in the repository (no other files in the repo need to be modified for this issue)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Partially addresses #18248
What does this implement/fix? Explain your changes.
This PR introduces
loss="log_loss"for SGDClassifier and deprecatesloss="log".Any other comments?