8000 DOC fix deprecated log loss argument in user guide by lorentzenchr · Pull Request #24753 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]

Skip to content

DOC fix deprecated log loss argument in user guide #24753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

lorentzenchr
Copy link
Member

Reference Issues/PRs

Follow up of #23046.

What does this implement/fix? Explain your changes.

2 instances of loss "log" for SGDClassifier remained uncatched and are now replaced by "log_loss".

@lorentzenchr lorentzenchr added No Changelog Needed Quick Review For PRs that are quick to review labels Oct 25, 2022
Copy link
Member
@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan thomasjpfan merged commit 55b55af into scikit-learn:main Oct 25, 2022
@lorentzenchr
Copy link
Member Author

Fastest time from PR opening to merging in my life so far 😁

@lorentzenchr lorentzenchr deleted the fix_user_guide_SGDClassifier branch October 25, 2022 14:55
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Oct 31, 2022
andportnoy pushed a commit to andportnoy/scikit-learn that referenced this pull request Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0