8000 DOC Improve get_feature_names_out docstrings by ogrisel · Pull Request #22718 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]

Skip to content

DOC Improve get_feature_names_out docstrings #22718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ogrisel
Copy link
Member
@ogrisel ogrisel commented Mar 7, 2022

As discussed when reviewing #22695.

I also fixed the indentation style of the item lists although I did not conduct a thorough review of which style should be followed in scikit-learn.

@ogrisel
Copy link
Member Author
ogrisel commented Mar 7, 2022

I realized that I did not commit all the changes I wanted to include in this PR. Let me fix that.

@ogrisel
Copy link
Member Author
ogrisel commented Mar 7, 2022

Done.

Copy link
Member
@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan thomasjpfan changed the title Improve get_feature_names_out docstrings DOC Improve get_feature_names_out docstrings Mar 7, 2022
@thomasjpfan
Copy link
Member

The remaining ones are:

`[x0, x1, ..., x(n_features_in_)]`.

input names are named `[x0, x1, ..., x(n_features_in_)]`.

@thomasjpfan thomasjpfan merged commit 279388d into scikit-learn:main Mar 7, 2022
@ogrisel ogrisel deleted the fix-generated-feature-names-docstring branch March 8, 2022 17:51
@ogrisel
Copy link
Member Author
ogrisel commented Mar 8, 2022

Thanks for the fix!

8498

thomasjpfan added a commit to thomasjpfan/scikit-learn that referenced this pull request Mar 8, 2022
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0