10000 ENH Adds feature_names_out to stacking estimators by thomasjpfan · Pull Request #22695 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

ENH Adds feature_names_out to stacking estimators #22695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Mar 8, 2022
Merged

ENH Adds feature_names_out to stacking estimators #22695

merged 9 commits into from
Mar 8, 2022

Conversation

thomasjpfan
Copy link
Member

Reference Issues/PRs

Towards #21308

What does this implement/fix? Explain your changes.

This PR adds get_feature_names_out to Stacking. The feature names uses the name of the estimator that generated the prediction.

Any other comments?

The test_transformers_get_feature_names_out common tests will run on these estimators because they define get_feature_names_out:

scikit-learn/sklearn/tests/test_common.py

Lines 394 to 396 in 1c24595

def _include_in_get_feature_names_out_check(transformer):
if hasattr(transformer, "get_feature_names_out"):
return True

@thomasjpfan thomasjpfan changed the title ENH Adds feature_names_out to stacking estiamtors ENH Adds feature_names_out to stacking estimators Mar 5, 2022
@thomasjpfan thomasjpfan mentioned this pull request Mar 5, 2022
Closed
14 tasks
@thomasjpfan thomasjpfan added this to the 1.1 milestone Mar 5, 2022
ogrisel
ogrisel reviewed Mar 7, 2022
View reviewed changes
Copy link
Member
@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Here are some comments below.

For information, I checked that StackingRegressor does not currently allow multi-target regression, even if the base regressors do.

If it were the case the code should be adjusted accordingly, or at least a new test should be added to check that it works as expected.

@ogrisel ogrisel mentioned this pull request Mar 7, 2022
Merged
ogrisel
ogrisel approved these changes Mar 8, 2022
View reviewed changes
Copy link
Member
@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

jeremiedbb
jeremiedbb approved these changes Mar 8, 2022
View reviewed changes
Copy link
Member
@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @thomasjpfan

@jeremiedbb jeremiedbb merged commit c2d0dcb into scikit-learn:main Mar 8, 2022
thomasjpfan added a commit to thomasjpfan/scikit-learn that referenced this pull request Mar 8, 2022
@thomasjpfan
ENH Adds feature_names_out to stacking estimators (scikit-learn#22695)
430a6ab
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Apr 6, 2022
@thomasjpfan @glemaitre
ENH Adds feature_names_out to stacking estimators (scikit-learn#22695)
a139b20
@eddiebergman eddiebergman mentioned this pull request Nov 15, 2022
Closed
54 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

@jeremiedbb jeremiedbb jeremiedbb approved these changes

Assignees
No one assigned
Labels
module:ensemble
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@thomasjpfan @ogrisel @jeremiedbb
0