TST check the legend instead of label names in CalibrationDisplay #21697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
versions This was changed in matplotlib 3.5.0 by: matplotlib/matplotlib@e7e6c8c#diff-501b7013d3efa42e08d1cc8dc7a27ee6944fcddb062cd7032249a0031bb01ff4R1641
glemaitre
reviewed
Nov 17, 2021
|
Is this related to this issue? #21690 |
|
yes |
ogrisel
approved these changes
Nov 17, 2021
|
The failure seems linked to this one: #21361 |
|
But that one's not reproduced after upgrading scipy? It seems like we can actually close that one since the OP can't reproduce it and it's fixed for them. |
|
I am merging this one. I will address the other issue as suggested by @ogrisel in the issue. |
jjerphan
added a commit
to jjerphan/scikit-learn
that referenced
this pull request
Nov 18, 2021
…ikit-learn#21697) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
glemaitre
added a commit
to glemaitre/scikit-learn
that referenced
this pull request
Nov 22, 2021
…ikit-learn#21697) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
glemaitre
added a commit
to glemaitre/scikit-learn
that referenced
this pull request
Nov 29, 2021
…ikit-learn#21697) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
samronsin
pushed a commit
to samronsin/scikit-learn
that referenced
this pull request
Nov 30, 2021
…ikit-learn#21697) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
glemaitre
added a commit
to glemaitre/scikit-learn
that referenced
this pull request
Dec 24, 2021
…ikit-learn#21697) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
glemaitre
added a commit
that referenced
this pull request
Dec 25, 2021
…1697) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #21690.
What does this implement/fix? Explain your changes.
test_calibration_display_default_labels[None-_line1]fails on main:https://dev.azure.com/scikit-learn/scikit-learn/_build/results?buildId=35071&view=logs&j=78a0bf4f-79e5-5387-94ec-13e67d216d6e&t=f1857171-4a53-55c7-3ab5-90acfe091baa&l=482
This originated from a change made in matplotlib 3.5.0 by:
matplotlib/matplotlib@e7e6c8c#diff-501b7013d3efa42e08d1cc8dc7a27ee6944fcddb062cd7032249a0031bb01ff4R1641
It should fix the failing test.
Any other comments?
/cc @glemaitre