10000 FIX validate parameter in fit for FactorAnalysis by HayaAlmutairi · Pull Request #21535 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

FIX validate parameter in fit for FactorAnalysis #21535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

FIX validate parameter in fit for FactorAnalysis #21535

wants to merge 1 commit into from

Conversation

HayaAlmutairi
Copy link
Contributor

Reference Issues/PRs
Addresses #21406

What does this implement/fix? Explain your changes.

  • Moves ValueError from init to _fit
  • checks ValueError in test_factor_analysis.py

cc: @krumeto

Any other comments?
#DataUmbrella

@HayaAlmutairi HayaAlmutairi deleted the factor_analysis_test_haya branch November 3, 2021 08:19
@reshamas reshamas added the Sprint label Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
module:decomposition Sprint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HayaAlmutairi @reshamas
0